Skip to content

fix: memory leak in completion resolve #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SimonSiefke wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: memory leak in completion resolve #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/vs/editor/contrib/suggest/browser/suggest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ export const Context = {

export const suggestWidgetStatusbarMenu = new MenuId('suggestWidgetStatusBar');

const emptyPromise = Promise.resolve();

export class CompletionItem {

_brand!: 'ISuggestionItem';
Expand Down Expand Up @@ -121,7 +123,7 @@ export class CompletionItem {

// create the suggestion resolver
if (typeof provider.resolveCompletionItem !== 'function') {
this._resolveCache = Promise.resolve();
this._resolveCache = emptyPromise;
this._resolveDuration = 0;
}
}
Expand Down
Loading