lint: Apply linter

Author: olivier-roussel

CMakeLists.txt

@@ -67,7 +67,7 @@ if(POLICY CMP0167)
   set(CMAKE_POLICY_DEFAULT_CMP0167 NEW)
 endif()
 include(${JRL_CMAKE_MODULES}/base.cmake)
-COMPUTE_PROJECT_ARGS(PROJECT_ARGS LANGUAGES CXX)
+compute_project_args(PROJECT_ARGS LANGUAGES CXX)
 project(${PROJECT_NAME} ${PROJECT_ARGS})
 set(CMAKE_VERBOSE_MAKEFILE OFF)
 
@@ -95,7 +95,7 @@ elseif(UNIX)
 endif()
 include(CMakeDependentOption)
 
-APPLY_DEFAULT_APPLE_CONFIGURATION()
+apply_default_apple_configuration()
 
 if(WIN32)
   set(LINK copy_if_different)
@@ -189,33 +189,33 @@ endif()
 # ----------------------------------------------------
 # --- DEPENDENCIES -----------------------------------
 # ----------------------------------------------------
-ADD_PROJECT_DEPENDENCY(
+add_project_dependency(
   Eigen3
   3.3.7
   REQUIRED
   PKG_CONFIG_REQUIRES "eigen3 >= 3.3.7"
 )
-ADD_PROJECT_DEPENDENCY(
+add_project_dependency(
   fmt
   REQUIRED
   PKG_CONFIG_REQUIRES "fmt >= 10.0.0"
 )
 
 if(BUILD_WITH_OPENMP_SUPPORT)
-  ADD_PROJECT_DEPENDENCY(OpenMP REQUIRED)
+  add_project_dependency(OpenMP REQUIRED)
   add_compile_definitions(ALIGATOR_MULTITHREADING)
 endif()
 
 set(BOOST_REQUIRED_COMPONENTS filesystem)
-SET_BOOST_DEFAULT_OPTIONS()
-EXPORT_BOOST_DEFAULT_OPTIONS()
-ADD_PROJECT_DEPENDENCY(Boost REQUIRED COMPONENTS ${BOOST_REQUIRED_COMPONENTS})
+set_boost_default_options()
+export_boost_default_options()
+add_project_dependency(Boost REQUIRED COMPONENTS ${BOOST_REQUIRED_COMPONENTS})
 
 if(BUILD_WITH_PINOCCHIO_SUPPORT)
   message(STATUS "Building aligator with Pinocchio support.")
 
   set(PINOCCHIO_MINIMUM_VERSION "3.4.0")
-  ADD_PROJECT_DEPENDENCY(
+  add_project_dependency(
     pinocchio
     ${PINOCCHIO_MINIMUM_VERSION}
     REQUIRED
@@ -232,7 +232,7 @@ endif()
 
 if(BUILD_PYTHON_INTERFACE)
   set(PYTHON_COMPONENTS Interpreter Development NumPy)
-  ADD_PROJECT_DEPENDENCY(
+  add_project_dependency(
     eigenpy
     3.9.0
     REQUIRED
@@ -313,7 +313,7 @@ if(ALIGATOR_TRACY_ENABLE AND DOWNLOAD_TRACY)
   endif()
 elseif(ALIGATOR_TRACY_ENABLE)
   # assume it is installed somewhere
-  ADD_PROJECT_DEPENDENCY(Tracy)
+  add_project_dependency(Tracy)
   if(NOT ${tracy_FOUND})
     message(
       FATAL_ERROR
@@ -385,12 +385,12 @@ function(create_library)
 endfunction()
 
 if(BUILD_STANDALONE_PYTHON_INTERFACE)
-  ADD_PROJECT_DEPENDENCY(${PROJECT_NAME} REQUIRED CONFIG)
+  add_project_dependency(${PROJECT_NAME} REQUIRED CONFIG)
 else()
   create_library()
 
-  ADD_HEADER_GROUP(LIB_HEADERS)
-  ADD_SOURCE_GROUP(LIB_SOURCES)
+  add_header_group(LIB_HEADERS)
+  add_source_group(LIB_SOURCES)
 
   install(
     TARGETS ${PROJECT_NAME}
@@ -414,7 +414,7 @@ if(DOWNLOAD_TRACY)
 endif()
 
 if(BUILD_CROCODDYL_COMPAT AND NOT BUILD_STANDALONE_PYTHON_INTERFACE)
-  ADD_PROJECT_DEPENDENCY(crocoddyl 3.0.1 REQUIRED)
+  add_project_dependency(crocoddyl 3.0.1 REQUIRED)
   add_subdirectory(src/compat/crocoddyl)
 endif()
 
@@ -452,7 +452,7 @@ macro(create_ex_or_bench exfile exname)
 endmacro()
 
 if(BUILD_WITH_PINOCCHIO_SUPPORT AND (BUILD_EXAMPLES OR BUILD_BENCHMARKS))
-  ADD_PROJECT_PRIVATE_DEPENDENCY(example-robot-data 4.0.9 REQUIRED)
+  add_project_private_dependency(example-robot-data 4.0.9 REQUIRED)
 endif()
 
 # create an utility library to avoid recompiling crocoddyl talos arm problem
@@ -564,11 +564,11 @@ if(BUILD_WITH_OPENMP_SUPPORT)
 endif()
 if(BUILD_CROCODDYL_COMPAT)
   EXPORT_VARIABLE(ALIGATOR_WITH_CROCODDYL_COMPAT ON)
-  PKG_CONFIG_APPEND_LIBS(aligator_croc_compat)
+  pkg_config_append_libs(aligator_croc_compat)
 endif()
 
-PKG_CONFIG_APPEND_LIBS(${PROJECT_NAME})
-PKG_CONFIG_APPEND_BOOST_LIBS(${BOOST_REQUIRED_COMPONENTS})
-PKG_CONFIG_APPEND_CFLAGS("${CFLAGS_DEPENDENCIES}")
+pkg_config_append_libs(${PROJECT_NAME})
+pkg_config_append_boost_libs(${BOOST_REQUIRED_COMPONENTS})
+pkg_config_append_cflags("${CFLAGS_DEPENDENCIES}")
 
-SETUP_PROJECT_FINALIZE()
+setup_project_finalize()

bindings/python/CMakeLists.txt

@@ -29,7 +29,7 @@ if(BUILD_CROCODDYL_COMPAT)
 endif()
 
 function(make_bindings)
-  Python3_add_library(
+  python3_add_library(
     ${PYLIB_NAME}
     MODULE
     WITH_SOABI
@@ -43,7 +43,7 @@ function(make_bindings)
     PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${PROJECT_NAME}
   )
   if(UNIX)
-    GET_RELATIVE_RPATH(${${PYLIB_NAME}_INSTALL_DIR} PYLIB_INSTALL_RPATH)
+    get_relative_rpath(${${PYLIB_NAME}_INSTALL_DIR} PYLIB_INSTALL_RPATH)
     set_target_properties(
       ${PYLIB_NAME}
       PROPERTIES INSTALL_RPATH "${PYLIB_INSTALL_RPATH}"
@@ -90,12 +90,12 @@ else()
 endif()
 # --- GENERATE STUBS
 if(GENERATE_PYTHON_STUBS)
-  PYTHON_BUILD_GET_TARGET(python_build_target_name)
-  LOAD_STUBGEN()
+  python_build_get_target(python_build_target_name)
+  load_stubgen()
   # Set PYWRAP and PROJECT_NAME as stubs dependencies.
   # PROJECT_NAME is mandatory (even if it's a PYWRAP dependency)
   # to find PROJECT_NAME name DLL on windows.
-  GENERATE_STUBS(
+  generate_stubs(
     ${CMAKE_CURRENT_BINARY_DIR}
     ${PROJECT_NAME}
     ${ABSOLUTE_PYTHON_SITELIB}
@@ -108,9 +108,9 @@ set(${PYLIB_NAME}_PYFILES __init__.py)
 set(${PYLIB_NAME}_PYFILES_UTILS __init__.py plotting.py)
 
 foreach(pyfile ${${PYLIB_NAME}_PYFILES})
-  PYTHON_INSTALL_ON_SITE(${PROJECT_NAME} ${pyfile})
+  python_install_on_site(${PROJECT_NAME} ${pyfile})
 endforeach()
 
 foreach(pyfile ${${PYLIB_NAME}_PYFILES_UTILS})
-  PYTHON_INSTALL_ON_SITE(${PROJECT_NAME}/utils ${pyfile})
+  python_install_on_site(${PROJECT_NAME}/utils ${pyfile})
 endforeach()

examples/CMakeLists.txt

@@ -29,7 +29,7 @@ if(NOT BUILD_STANDALONE_PYTHON_INTERFACE)
   endif()
 
   if(BUILD_CROCODDYL_COMPAT)
-    ADD_PROJECT_PRIVATE_DEPENDENCY(example-robot-data 4.0.9 REQUIRED)
+    add_project_private_dependency(example-robot-data 4.0.9 REQUIRED)
     create_example(
       talos-arm.cpp
       DEPENDENCIES aligator::croc_compat croc_talos_arm_utils

extra-python-macros.cmake

@@ -15,7 +15,7 @@ function(aligator_create_python_extension name)
   endforeach()
   set(_sources ${arg_UNPARSED_ARGUMENTS})
 
-  Python3_add_library(${name} ${_parse_oneValueArgs} ${_sources})
+  python3_add_library(${name} ${_parse_oneValueArgs} ${_sources})
   target_link_libraries(${name} PRIVATE eigenpy::eigenpy aligator::aligator)
   target_compile_definitions(${name} PRIVATE PYTHON_MODULE_NAME=${name})
 endfunction()

tests/CMakeLists.txt

@@ -21,7 +21,7 @@ function(add_aligator_test2 test_name dependencies)
   set(test_name "${PROJECT_NAME}-test-cpp-${test_name}")
   message(STATUS "Adding cpp test: ${test_name} (${test_file})")
 
-  ADD_UNIT_TEST(${test_name} ${test_file} ${TEST_HEADERS})
+  add_unit_test(${test_name} ${test_file} ${TEST_HEADERS})
   set_target_properties(${test_name} PROPERTIES LINKER_LANGUAGE CXX)
   set_standard_output_directory(${test_name})
   target_include_directories(${test_name} PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})

tests/python/CMakeLists.txt

@@ -36,7 +36,7 @@ foreach(pyfile ${PYTHON_TESTS})
       ${CMAKE_CURRENT_BINARY_DIR}/${pyfile}
   )
   message(STATUS "Adding Python test: ${test_name}")
-  ADD_PYTHON_UNIT_TEST(
+  add_python_unit_test(
     ${test_name}
     "tests/python/${pyfile}"
     "tests/python"
@@ -46,10 +46,10 @@ foreach(pyfile ${PYTHON_TESTS})
 endforeach()
 
 function(add_test_binding_lib test_name)
-  CREATE_CTEST_BUILD_TESTS_TARGET()
+  create_ctest_build_tests_target()
 
   set(target_name "${PROJECT_NAME}-${test_name}")
-  Python3_add_library(${target_name} MODULE "${test_name}.cpp")
+  python3_add_library(${target_name} MODULE "${test_name}.cpp")
   set_standard_output_directory(${target_name})
   target_link_libraries(${target_name} PUBLIC ${PYLIB_NAME})
   target_link_libraries(${target_name} PUBLIC eigenpy::eigenpy)