Split module.cpp

Author: ManifoldFR

CMakeLists.txt

@@ -82,7 +82,7 @@ target_include_directories(
 )
 target_link_libraries(nanoeigenpy_headers INTERFACE Eigen3::Eigen)
 
-file(GLOB ${PROJECT_NAME}_SOURCES src/*.cpp)
+set(${PROJECT_NAME}_SOURCES src/module.cpp src/solvers.cpp)
 nanobind_add_module(nanoeigenpy NB_STATIC NB_SUPPRESS_WARNINGS ${nanoeigenpy_SOURCES} ${nanoeigenpy_HEADERS})
 target_link_libraries(nanoeigenpy PRIVATE nanoeigenpy_headers)
 

src/internal.h

@@ -0,0 +1,9 @@
+#include <nanobind/nanobind.h>
+#include <Eigen/Core>
+
+namespace nb = nanobind;
+
+using Scalar = double;
+static constexpr int Options = Eigen::ColMajor;
+using Matrix = Eigen::Matrix<Scalar, -1, -1, Options>;
+using Vector = Eigen::Matrix<Scalar, -1, 1>;

src/module.cpp

@@ -1,21 +1,16 @@
 /// Copyright 2025 INRIA
 
-#include <nanobind/nanobind.h>
 #include <nanobind/stl/string.h>
 
 #include "nanoeigenpy/decompositions.hpp"
 #include "nanoeigenpy/geometry.hpp"
-#include "nanoeigenpy/solvers.hpp"
 #include "nanoeigenpy/utils/is-approx.hpp"
 #include "nanoeigenpy/constants.hpp"
 
+#include "./internal.h"
+
 using namespace nanoeigenpy;
-namespace nb = nanobind;
 
-using Scalar = double;
-static constexpr int Options = Eigen::ColMajor;
-using Matrix = Eigen::Matrix<Scalar, -1, -1, Options>;
-using Vector = Eigen::Matrix<Scalar, -1, 1>;
 using Quaternion = Eigen::Quaternion<Scalar, Options>;
 using SparseMatrix = Eigen::SparseMatrix<Scalar, Options>;
 
@@ -84,28 +79,3 @@ NB_MODULE(nanoeigenpy, m) {
         "Get the set of SIMD instructions used in Eigen when this module was "
         "compiled.");
 }
-
-void exposeSolvers(nb::module_& m) {
-  exposeIdentityPreconditioner<Scalar>(m, "IdentityPreconditioner");
-  exposeDiagonalPreconditioner<Scalar>(m, "DiagonalPreconditioner");
-#if EIGEN_VERSION_AT_LEAST(3, 3, 5)
-  exposeLeastSquareDiagonalPreconditioner<Scalar>(
-      m, "LeastSquareDiagonalPreconditioner");
-#endif
-
-  // Solvers
-  using Eigen::Lower;
-  using Eigen::Upper;
-  using ConjugateGradient = Eigen::ConjugateGradient<Matrix, Lower | Upper>;
-  exposeConjugateGradient<ConjugateGradient>(m, "ConjugateGradient");
-  using LeastSquaresConjugateGradient = Eigen::LeastSquaresConjugateGradient<
-      Matrix, Eigen::LeastSquareDiagonalPreconditioner<Scalar>>;
-  exposeLeastSquaresConjugateGradient<LeastSquaresConjugateGradient>(
-      m, "LeastSquaresConjugateGradient");
-
-  using IdentityConjugateGradient =
-      Eigen::ConjugateGradient<Matrix, Lower | Upper,
-                               Eigen::IdentityPreconditioner>;
-  exposeConjugateGradient<IdentityConjugateGradient>(
-      m, "IdentityConjugateGradient");
-}

src/solvers.cpp

@@ -0,0 +1,34 @@
+#include "nanoeigenpy/solvers.hpp"
+
+#include "./internal.h"
+
+using namespace nanoeigenpy;
+
+void exposeSolvers(nb::module_& m) {
+  exposeIdentityPreconditioner<Scalar>(m, "IdentityPreconditioner");
+  exposeDiagonalPreconditioner<Scalar>(m, "DiagonalPreconditioner");
+#if EIGEN_VERSION_AT_LEAST(3, 3, 5)
+  exposeLeastSquareDiagonalPreconditioner<Scalar>(
+      m, "LeastSquareDiagonalPreconditioner");
+#endif
+
+  // Solvers
+  using Eigen::ConjugateGradient;
+  using Eigen::IdentityPreconditioner;
+  using Eigen::LeastSquareDiagonalPreconditioner;
+  using Eigen::LeastSquaresConjugateGradient;
+  using Eigen::Lower;
+  using Eigen::Upper;
+
+  exposeConjugateGradient<ConjugateGradient<Matrix, Lower | Upper>>(
+      m, "ConjugateGradient");
+
+  exposeLeastSquaresConjugateGradient<LeastSquaresConjugateGradient<
+      Matrix, LeastSquareDiagonalPreconditioner<Scalar>>>(
+      m, "LeastSquaresConjugateGradient");
+
+  using IdentityConjugateGradient =
+      ConjugateGradient<Matrix, Lower | Upper, IdentityPreconditioner>;
+  exposeConjugateGradient<IdentityConjugateGradient>(
+      m, "IdentityConjugateGradient");
+}