Merge pull request #6 from Simple-Robotics/macro-headers-cleanup

Macro headers cleanup

Author: ManifoldFR

CHANGELOG.md

@@ -19,6 +19,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Changed
 
 - bindings/python : Add missing arg names in `visualizer-visitor.hpp`
+- use deprecation, warning macros already provided by jrl-cmakemodules
+
+### Removed
+
+- Remove unused headers `deprecated-macros.hpp` and `deprecated-namespaces.hpp`
+- Remove header `pinocchio/deprecation.hpp`, directly use generated `pinocchio/deprecated.hpp`
+- macros.hpp : remove macros already provided by jrl-cmakemodules
 
 ## [3.7.0] - 2025-05-21
 

include/pinocchio/algorithm/parallel/geometry.hpp

@@ -8,7 +8,7 @@
 #include "pinocchio/macros.hpp"
 
 // clang-format off
-PINOCCHIO_PRAGMA_DEPRECATED_HEADER(pinocchio/algorithm/parallel/geometry.hpp, pinocchio/collision/parallel/geometry.hpp)
+PINOCCHIO_DEPRECATED_HEADER(pinocchio/algorithm/parallel/geometry.hpp, pinocchio/collision/parallel/geometry.hpp)
 // clang-format on
 
 #include "pinocchio/collision/parallel/geometry.hpp"

include/pinocchio/algorithm/parallel/omp.hpp

@@ -6,7 +6,7 @@
 #define __pinocchio_algorithm_parallel_omp_hpp__
 
 #include "pinocchio/macros.hpp"
-PINOCCHIO_PRAGMA_DEPRECATED_HEADER(
+PINOCCHIO_DEPRECATED_HEADER(
   pinocchio / algorithm / parallel / omp.hpp, pinocchio / utils / openmp.hpp)
 #include "pinocchio/utils/openmp.hpp"
 

include/pinocchio/bindings/python/parsers/python.hpp

@@ -8,7 +8,7 @@
 #include "pinocchio/macros.hpp"
 
 // clang-format off
-PINOCCHIO_PRAGMA_DEPRECATED_HEADER(pinocchio/bindings/python/parsers/python.hpp, pinocchio/parsers/python.hpp)
+PINOCCHIO_DEPRECATED_HEADER(pinocchio/bindings/python/parsers/python.hpp, pinocchio/parsers/python.hpp)
 // clang-format on
 
 #include "pinocchio/parsers/python.hpp"

include/pinocchio/deprecated-macros.hpp

@@ -26,7 +26,7 @@ namespace pinocchio
 #endif
 
 #include "pinocchio/macros.hpp"
-#include "pinocchio/deprecation.hpp"
+#include "pinocchio/deprecated.hpp"
 #include "pinocchio/warning.hpp"
 #include "pinocchio/config.hpp"
 #include "pinocchio/unsupported.hpp"

include/pinocchio/deprecated-namespaces.hpp

@@ -6,7 +6,8 @@
 #ifndef __pinocchio_macros_hpp__
 #define __pinocchio_macros_hpp__
 
-#include <sstream>
+#include "pinocchio/deprecated.hpp"
+#include "pinocchio/warning.hpp"
 
 // On Windows, __cplusplus is not necessarily set to the C++ version being used.
 // See https://docs.microsoft.com/fr-fr/cpp/build/reference/zc-cplusplus?view=vs-2019 for further
@@ -36,28 +37,8 @@
   #define PINOCCHIO_MAC_ARM64
 #endif
 
-#define PINOCCHIO_STRING_LITERAL(string) #string
 #define PINOCCHIO_NOEXCEPT noexcept
 
-// For more details, visit
-// https://stackoverflow.com/questions/171435/portability-of-warning-preprocessor-directive
-#if defined(__GNUC__) || defined(__clang__)
-  #define PINOCCHIO_PRAGMA(x) _Pragma(#x)
-  #define PINOCCHIO_PRAGMA_MESSAGE(the_message) PINOCCHIO_PRAGMA(GCC message #the_message)
-  #define PINOCCHIO_PRAGMA_WARNING(the_message) PINOCCHIO_PRAGMA(GCC warning #the_message)
-  #define PINOCCHIO_PRAGMA_DEPRECATED(the_message)                                                 \
-    PINOCCHIO_PRAGMA_WARNING(Deprecated : #the_message)
-  #define PINOCCHIO_PRAGMA_DEPRECATED_HEADER(old_header, new_header)                               \
-    PINOCCHIO_PRAGMA_WARNING(Deprecated header file : #old_header has been replaced                \
-                               by #new_header.\n Please use #new_header instead of #old_header.)
-#else
-  #define PINOCCHIO_PRAGMA(x)
-  #define PINOCCHIO_PRAGMA_MESSAGE(the_message)
-  #define PINOCCHIO_PRAGMA_WARNING(the_message)
-  #define PINOCCHIO_PRAGMA_DEPRECATED(the_message)
-  #define PINOCCHIO_PRAGMA_DEPRECATED_HEADER(old_header, new_header)
-#endif
-
 /// \brief Function attribute to forbid inlining.
 /// This is a compiler hint that can be not respected.
 #define PINOCCHIO_DONT_INLINE EIGEN_DONT_INLINE
@@ -244,7 +225,7 @@ PINOCCHIO_COMPILER_DIAGNOSTIC_IGNORED_VARIADIC_MACROS
 #define _PINOCCHIO_CHECK_ARGUMENT_SIZE_2(size, expected_size)                                      \
   _PINOCCHIO_CHECK_ARGUMENT_SIZE_3(                                                                \
     size, expected_size,                                                                           \
-    PINOCCHIO_STRING_LITERAL(size) " is different from " PINOCCHIO_STRING_LITERAL(expected_size))
+    PINOCCHIO_WARN_STRINGISE(size) " is different from " PINOCCHIO_WARN_STRINGISE(expected_size))
 
 #define _PINOCCHIO_CHECK_ARGUMENT_SIZE_1
 

include/pinocchio/deprecation.hpp

@@ -8,7 +8,7 @@
 #include "pinocchio/macros.hpp"
 
 // clang-format off
-PINOCCHIO_PRAGMA_DEPRECATED_HEADER(pinocchio/math/casadi.hpp, pinocchio/autodiff/casadi.hpp)
+PINOCCHIO_DEPRECATED_HEADER(pinocchio/math/casadi.hpp, pinocchio/autodiff/casadi.hpp)
 // clang-format on
 
 #include "pinocchio/autodiff/casadi.hpp"