release: updates #361
Merged
release: updates #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabinsch
force-pushed
the
devel
branch
2 times, most recently
from
706bc10 to
898270b
Compare
Collaborator
Member
|
@nim65s You can now rebase your branch ;) |
fabinsch
reviewed
Jan 20, 2025
Collaborator
fabinsch
left a comment
fabinsch
left a comment
There was a problem hiding this comment.
Looks good to me. I would say we can also include PyPy 3.10 and we can remove the lines related to PYPI_TOKEN in both release-linux.yml and release-osx-win.yml as I have created a Trusted Publisher on pypi.
fabinsch
approved these changes
Jan 20, 2025
Collaborator
fabinsch
left a comment
fabinsch
left a comment
There was a problem hiding this comment.
This is good to merge now. Afterward, we will proceed to a new release of Proxsuite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think we would need some python 3.13 release on PyPI.
While here, I updated a few other things in the release workflows.
Also, the PYPI_TOKEN should be removed in favor of then new "Trusted Publisher Management": https://pypi.org/manage/project/proxsuite/settings/publishing/