Skip to content

Conversation

@live627
Copy link
Contributor

@live627 live627 commented Nov 1, 2024

Motivation

I have a modification (Topic Descriptions) that needs access to this, so we'll use Msg::load() which eventually calls integrate_query_message

Idea

$query_customizations could become its own object.

@live627 live627 added Housekeeping SMF code reorganization Hooks labels Nov 1, 2024
@live627 live627 requested a review from jdarwood007 November 1, 2024 09:24
@jdarwood007
Copy link
Member

Haven't run the code but looks good.

I'm in support of more objects for everything. It makes things much easier to develop. But we have to contend with how it would support customizations. Magic methods maybe can help there.

@DiegoAndresCortes
Copy link
Member

I like it, same thing we got for messageindex, the more places the better imo

@tyrsson
Copy link
Collaborator

tyrsson commented Nov 2, 2024

From a customization perspective. If you model the instances that need to support customization as Observable then mods can be notified via their own registered listeners.

@Sesquipedalian Sesquipedalian merged commit d44d12d into SimpleMachines:release-3.0 Nov 28, 2024
6 checks passed
@live627 live627 deleted the quotefast branch January 28, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hooks Housekeeping SMF code reorganization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants