Skip to content

Fixes some bugs in WebFetchApi #8347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sesquipedalian merged 4 commits into from
Dec 18, 2024
Merged

Fixes some bugs in WebFetchApi #8347

Sesquipedalian merged 4 commits into from
Dec 18, 2024

Conversation

@Sesquipedalian
Copy link
Member

@Sesquipedalian Sesquipedalian commented Nov 28, 2024 •
edited
Loading

  1. Ensures that we don't ignore the $post_data parameter in WebFetchApi::fetch().
  2. Uses correct value types in CurlFetcher::$default_options.
  3. Ensures that the CurlFetcher class always handles redirection itself.
  4. Respects the $keep_alive parameter in WebFetchApi::fetch().

@Sesquipedalian Sesquipedalian added the External data Fetching, processing, and using external data label Nov 28, 2024
@Sesquipedalian Sesquipedalian added this to the 3.0 Alpha 3 milestone Nov 28, 2024
@Sesquipedalian Sesquipedalian merged commit ba9a582 into SimpleMachines:release-3.0 Dec 18, 2024
6 checks passed
@Sesquipedalian Sesquipedalian deleted the 3.0/webfetchapi_improvments branch December 18, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

External data Fetching, processing, and using external data

Projects

None yet

Milestone

3.0 Alpha 3

Development

Successfully merging this pull request may close these issues.

1 participant

@Sesquipedalian