Improvements to iCalendar support for SMF's calendar #8348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Sesquipedalian
force-pushed
the
3.0/calendar_improvements
branch
3 times, most recently
from
840fed3 to
38dfb0d
Compare
Member
|
How annoying will it be to update those files? Especially for patch releases? |
Contributor
|
There's a script to update them, just like the unicode tables. Auto correct really really wanted to make this post about unicorns. |
Member
Author
Correct. I have now added documentation notes to remind future developers about this. |
Signed-off-by: Jon Stovell <[email protected]>
Sesquipedalian
force-pushed
the
3.0/calendar_improvements
branch
from
3aab760 to
8356422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item 3 was a pain in the butt, but necessary to conform to the spec. (Personally, I think it is stupid that the spec requires including information about all the timing and rules that govern when a given time zone switches between standard time and daylight saving time, rather than just giving the time zone identifier and letting the calendar software handle it directly, but that's just the way it is.)