[3.0] Rewrites installer and upgrader

[Sesquipedalian]

This is the new installer and upgrader code. It is based on the work in #8093.

It works in my tests, but it probably has bugs. Let's find 'em and fix 'em.

Fixes #7954
Fixes #8261
Fixes #8570
Fixes #8599
Fixes #8616
Fixes #8648
Fixes #8683

[jdarwood007]

Is 2.0 and before stuff going up separately?

[Sesquipedalian]

Is 2.0 and before stuff going up separately?

This PR already includes the necessary migration steps to upgrade from 2.0. We had previously discussed the plan to make upgrading from 1.x a separate converter.

[jdarwood007]

Is 2.0 and before stuff going up separately?

This PR already includes the necessary migration steps to upgrade from 2.0. We had previously discussed the plan to make upgrading from 1.x a separate converter.

I had planned to bake the converter logic into the installer/upgrader to make it still easy to convert Yabb, SMF 1.x and 2.0. The reason is that we are still supporting them, but only through a conversion process. Yabb and SMF 1.x cost a lot of technical debt to maintain the upgrader logic for. So by moving into converters, we reduce that to maintaining how to convert data, which becomes easier with a select this and insert that process.

[Sesquipedalian]

Sure. But that would all just be a matter of writing Migration and Cleanup classes, plus a Tools class to call them, right?

[sbulen]

I just ran a 2.1 =>3.0 upgrade & it went very well.

EDIT: I had to rerun for... reasons... Different issues reported below...

On completion, I got this error in the Cleanup phase:
Critical Error!
fileinode(): Argument # 1 ($filename) must be of type string, false given
D:\wamp64\www\van2130\Sources\Maintenance\Cleanup\v3_0\TasksDirCase.php:62

[Oldiesmann]

The "SMF\Db\Schema\Lang not found" errors indicate we're trying to call methods in the SMF\Lang class while in the SMF\Db\Schema namespace. Should be an easy fix though.

[Sesquipedalian]

The "SMF\Db\Schema\Lang not found" errors indicate we're trying to call methods in the SMF\Lang class while in the SMF\Db\Schema namespace. Should be an easy fix though.

Fixed now.

[jdarwood007]

Why are we deleting files? The purpose was to leave them around.

[Sesquipedalian]

We are only deleting the ones that will never be needed again. For example, once the upgrade to 3.0 has been completed, we will never need the migration steps for 2.0 → 2.1 again, nor the database schema files for 2.1. Conversely, we do keep the schema files and migration steps for 3.0, because we might very well use them again.

[jdarwood007]

This PR should address #8683 as well

[Sesquipedalian]

Good idea

[jdarwood007]

I found one more, #8241 makes sense to handle here. Not for 2.1, but something we can do here by updating the error message to include it. I am not seeing any other issue for installer that isn't linked to this PR.

[jdarwood007]

I also see #7615
But I think that is resolved with the rewrite in the first place.

I also see #7551
I need to check on that one. Maybe related to #8241

[Sesquipedalian]

I'm going to go ahead and merge this now. If any new issues with it arise afterward, we can fix them then.