[3.0] Fix quotes in names for mention handling #8837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SimpleMachines#8820 Big note, 2.1 handled names differently so a bit of compatibility had to be added here. If SimpleMachines#8132 is accepted then it needs to ensure it doesn't reintroduce this issue.
Member
Hm. That wasn't an intentional change. I think it indicates a deeper problem that must be fixed first. I will look into it. In the meantime, I will leave this PR here. |
Member
Author
|
I guessed that we had stopped mucking up entities somewhat and that we would see less of this in the future. Seems now that during the transition of code, some |
Member
|
Yeah. I have a PR nearly ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8820
Big note, 2.1 handled names differently, so a bit of compatibility had to be added here.
If #8132 is accepted, then it needs to ensure it doesn't reintroduce this issue.
@Sesquipedalian I am not happy with how the fix had to come out for handling the entities issue. If you have a better idea, please chime in or introduce an alternative PR.
I tested by changing a member's name to
Apasta'fee. In SMF 2.1, the database value isApasta'feeand in 3.0 it isApasta'fee. 2.1 and 3.0 both handle a double quote the same by encoding it (i.e.,Double"Quotes)