Skip to content

Conversation

@sbulen
Copy link
Contributor

@sbulen sbulen commented Oct 27, 2025

Fixes #9012

Note that it was important to pass the whole key, not just an auto inc column, to address the query issues. Not all keys are just auto incs.

Further, the old logic wouldn't add a key unless it was a passed column in the query, but pg didn't like that because it wasn't always the complete unique/primary key (e.g., auto incs usually excluded). So had to ensure it passed all pk elements, all the time.

Another possible solution would have been to remove the conflict target (key list in parens) entirely. This solution felt a little more holistic, however, as it addressed the broader issue with Table.php as well.

Tests great; no more hidden errors. Freshly installed pg 3.0 database is fully populated.

@jdarwood007 jdarwood007 added this to the 3.0 Alpha 5 milestone Oct 27, 2025
@jdarwood007 jdarwood007 merged commit af86a96 into SimpleMachines:release-3.0 Oct 27, 2025
7 checks passed
@sbulen sbulen deleted the 30_pg_data_population branch November 6, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3.0]: pg install: database not properly populated

2 participants