Skip to content

Commit 208366b

Browse files
committed
fix a glitch with misaligned Company icon if just the job position is filled
1 parent c4ac5a2 commit 208366b

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

app/src/main/kotlin/com/simplemobiletools/contacts/activities/ViewContactActivity.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,12 +354,16 @@ class ViewContactActivity : ContactActivity() {
354354

355355
private fun setupOrganization() {
356356
val organization = contact!!.organization
357-
if (!organization.isEmpty() && showFields and SHOW_ORGANIZATION_FIELD != 0) {
357+
if (organization.isNotEmpty() && showFields and SHOW_ORGANIZATION_FIELD != 0) {
358358
contact_organization_company.text = organization.company
359359
contact_organization_job_position.text = organization.jobPosition
360360
contact_organization_image.beGoneIf(organization.isEmpty())
361361
contact_organization_company.beGoneIf(organization.company.isEmpty())
362362
contact_organization_job_position.beGoneIf(organization.jobPosition.isEmpty())
363+
364+
if (organization.company.isEmpty() && organization.jobPosition.isNotEmpty()) {
365+
(contact_organization_image.layoutParams as RelativeLayout.LayoutParams).addRule(RelativeLayout.ALIGN_TOP, contact_organization_job_position.id)
366+
}
363367
} else {
364368
contact_organization_image.beGone()
365369
contact_organization_company.beGone()

app/src/main/kotlin/com/simplemobiletools/contacts/helpers/ContactsHelper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1313,7 +1313,7 @@ class ContactsHelper(val activity: Activity) {
13131313
}
13141314

13151315
// organization
1316-
if (!contact.organization.isEmpty()) {
1316+
if (contact.organization.isNotEmpty()) {
13171317
ContentProviderOperation.newInsert(ContactsContract.Data.CONTENT_URI).apply {
13181318
withValueBackReference(ContactsContract.Data.RAW_CONTACT_ID, 0)
13191319
withValue(ContactsContract.Data.MIMETYPE, CommonDataKinds.Organization.CONTENT_ITEM_TYPE)

app/src/main/kotlin/com/simplemobiletools/contacts/helpers/VcfExporter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ class VcfExporter {
122122
card.addNote(contact.notes)
123123
}
124124

125-
if (!contact.organization.isEmpty()) {
125+
if (contact.organization.isNotEmpty()) {
126126
val organization = Organization()
127127
organization.values.add(contact.organization.company)
128128
card.organization = organization

0 commit comments

Comments
 (0)