Skip to content

Commit 32f7309

Browse files
tibbitibbi
committed
removing some redundant setting layout rules
1 parent b45bc78 commit 32f7309

File tree

1 file changed

+19
-23
lines changed

1 file changed

+19
-23
lines changed

‎app/src/main/res/layout/activity_settings.xml‎

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<ScrollView
3-
xmlns:android="http://schemas.android.com/apk/res/android"
2+
<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
43
xmlns:app="http://schemas.android.com/apk/res-auto"
54
android:id="@+id/settings_scrollview"
65
android:layout_width="match_parent"
@@ -29,7 +28,7 @@
2928
android:layout_height="wrap_content"
3029
android:layout_centerVertical="true"
3130
android:paddingStart="@dimen/medium_margin"
32-
android:text="@string/customize_colors"/>
31+
android:text="@string/customize_colors" />
3332

3433
</RelativeLayout>
3534

@@ -52,7 +51,7 @@
5251
android:clickable="false"
5352
android:paddingStart="@dimen/medium_margin"
5453
android:text="@string/use_english_language"
55-
app:switchPadding="@dimen/medium_margin"/>
54+
app:switchPadding="@dimen/medium_margin" />
5655

5756
</RelativeLayout>
5857

@@ -73,8 +72,7 @@
7372
android:layout_height="wrap_content"
7473
android:layout_centerVertical="true"
7574
android:paddingStart="@dimen/medium_margin"
76-
android:paddingLeft="@dimen/medium_margin"
77-
android:text="@string/manage_favorites"/>
75+
android:text="@string/manage_favorites" />
7876

7977
</RelativeLayout>
8078

@@ -95,7 +93,7 @@
9593
android:layout_height="wrap_content"
9694
android:layout_centerVertical="true"
9795
android:paddingStart="@dimen/medium_margin"
98-
android:text="@string/change_date_and_time_format"/>
96+
android:text="@string/change_date_and_time_format" />
9997

10098
</RelativeLayout>
10199

@@ -118,7 +116,7 @@
118116
android:layout_toStartOf="@+id/settings_font_size"
119117
android:paddingLeft="@dimen/medium_margin"
120118
android:paddingRight="@dimen/medium_margin"
121-
android:text="@string/font_size"/>
119+
android:text="@string/font_size" />
122120

123121
<com.simplemobiletools.commons.views.MyTextView
124122
android:id="@+id/settings_font_size"
@@ -127,7 +125,7 @@
127125
android:layout_alignParentEnd="true"
128126
android:layout_marginEnd="@dimen/medium_margin"
129127
android:background="@null"
130-
android:clickable="false"/>
128+
android:clickable="false" />
131129

132130
</RelativeLayout>
133131

@@ -136,18 +134,17 @@
136134
android:layout_width="match_parent"
137135
android:layout_height="1px"
138136
android:background="@color/divider_grey"
139-
android:importantForAccessibility="no"/>
137+
android:importantForAccessibility="no" />
140138

141139
<com.simplemobiletools.commons.views.MyTextView
142140
android:id="@+id/visibility_label"
143141
android:layout_width="wrap_content"
144142
android:layout_height="wrap_content"
145143
android:layout_marginStart="@dimen/bigger_margin"
146-
android:layout_marginLeft="@dimen/bigger_margin"
147144
android:layout_marginTop="@dimen/activity_margin"
148145
android:text="@string/visibility"
149146
android:textAllCaps="true"
150-
android:textSize="@dimen/smaller_text_size"/>
147+
android:textSize="@dimen/smaller_text_size" />
151148

152149
<RelativeLayout
153150
android:id="@+id/settings_show_hidden_holder"
@@ -168,7 +165,7 @@
168165
android:clickable="false"
169166
android:paddingStart="@dimen/medium_margin"
170167
android:text="@string/show_hidden_items"
171-
app:switchPadding="@dimen/medium_margin"/>
168+
app:switchPadding="@dimen/medium_margin" />
172169

173170
</RelativeLayout>
174171

@@ -177,7 +174,7 @@
177174
android:layout_width="match_parent"
178175
android:layout_height="1px"
179176
android:background="@color/divider_grey"
180-
android:importantForAccessibility="no"/>
177+
android:importantForAccessibility="no" />
181178

182179
<com.simplemobiletools.commons.views.MyTextView
183180
android:id="@+id/file_operations_label"
@@ -187,7 +184,7 @@
187184
android:layout_marginTop="@dimen/activity_margin"
188185
android:text="@string/file_operations"
189186
android:textAllCaps="true"
190-
android:textSize="@dimen/smaller_text_size"/>
187+
android:textSize="@dimen/smaller_text_size" />
191188

192189
<RelativeLayout
193190
android:id="@+id/settings_keep_last_modified_holder"
@@ -208,7 +205,7 @@
208205
android:clickable="false"
209206
android:paddingStart="@dimen/medium_margin"
210207
android:text="@string/keep_last_modified"
211-
app:switchPadding="@dimen/medium_margin"/>
208+
app:switchPadding="@dimen/medium_margin" />
212209

213210
</RelativeLayout>
214211

@@ -217,7 +214,7 @@
217214
android:layout_width="match_parent"
218215
android:layout_height="1px"
219216
android:background="@color/divider_grey"
220-
android:importantForAccessibility="no"/>
217+
android:importantForAccessibility="no" />
221218

222219
<com.simplemobiletools.commons.views.MyTextView
223220
android:id="@+id/security_label"
@@ -227,7 +224,7 @@
227224
android:layout_marginTop="@dimen/activity_margin"
228225
android:text="@string/security"
229226
android:textAllCaps="true"
230-
android:textSize="@dimen/smaller_text_size"/>
227+
android:textSize="@dimen/smaller_text_size" />
231228

232229
<RelativeLayout
233230
android:id="@+id/settings_password_protection_holder"
@@ -248,7 +245,7 @@
248245
android:clickable="false"
249246
android:paddingStart="@dimen/medium_margin"
250247
android:text="@string/password_protect_hidden_items"
251-
app:switchPadding="@dimen/medium_margin"/>
248+
app:switchPadding="@dimen/medium_margin" />
252249

253250
</RelativeLayout>
254251

@@ -271,7 +268,7 @@
271268
android:clickable="false"
272269
android:paddingStart="@dimen/medium_margin"
273270
android:text="@string/password_protect_whole_app"
274-
app:switchPadding="@dimen/medium_margin"/>
271+
app:switchPadding="@dimen/medium_margin" />
275272

276273
</RelativeLayout>
277274

@@ -294,7 +291,7 @@
294291
android:clickable="false"
295292
android:paddingStart="@dimen/medium_margin"
296293
android:text="@string/password_protect_file_deletion"
297-
app:switchPadding="@dimen/medium_margin"/>
294+
app:switchPadding="@dimen/medium_margin" />
298295

299296
</RelativeLayout>
300297

@@ -316,9 +313,8 @@
316313
android:background="@null"
317314
android:clickable="false"
318315
android:paddingStart="@dimen/medium_margin"
319-
android:paddingLeft="@dimen/medium_margin"
320316
android:text="@string/enable_root_access"
321-
app:switchPadding="@dimen/medium_margin"/>
317+
app:switchPadding="@dimen/medium_margin" />
322318

323319
</RelativeLayout>
324320
</LinearLayout>

0 commit comments

Comments
 (0)