Skip to content

Commit f305aad

Browse files
Martynas ŽilinskasDovydasNavickas
authored andcommitted
Validation Promise<any> to Promise<never>.
1 parent d596362 commit f305aad

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

packages/simplr-forms-core/__tests__/stores/form-store.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ describe("Form store", () => {
101101
const formStore = new FormStore(formId);
102102

103103
formStore.RegisterField(fieldId, initialValue, defaultValue);
104-
const validationPromise = new Promise<void>((resolve, reject) => {
104+
const validationPromise = new Promise<never>((resolve, reject) => {
105105
setTimeout(() => {
106106
resolve();
107107
}, 50);
@@ -132,7 +132,7 @@ describe("Form store", () => {
132132
const formError: FormError = { Message: "Error Message" };
133133

134134
formStore.RegisterField(fieldId, initialValue, defaultValue);
135-
const validationPromise = new Promise<void>((resolve, reject) => {
135+
const validationPromise = new Promise<never>((resolve, reject) => {
136136
setTimeout(() => {
137137
reject(formError);
138138
}, 50);
@@ -174,7 +174,7 @@ describe("Form store", () => {
174174
const formError = "field error";
175175

176176
formStore.RegisterField(fieldId, initialValue, defaultValue);
177-
const validationPromise = new Promise<void>((resolve, reject) => {
177+
const validationPromise = new Promise<never>((resolve, reject) => {
178178
setTimeout(() => {
179179
reject(formError);
180180
}, 50);

packages/simplr-forms-core/src/stores/form-store.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export class FormStore extends ActionEmitter {
138138
this.emit(new Actions.ValueChanged(fieldId, newValue));
139139
}
140140

141-
public async Validate(fieldId: string, validationPromise: Promise<void>) {
141+
public async Validate(fieldId: string, validationPromise: Promise<never>) {
142142
const field = this.State.Fields.get(fieldId);
143143
const fieldValue = field.Value;
144144

packages/simplr-forms-dom/src/contracts/form.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ import { FieldValue, FormError } from "simplr-forms-core/contracts";
33
import { FormStore } from "simplr-forms-core/stores";
44

55
export interface FormOnSubmitCallback extends React.FormEventHandler<HTMLFormElement> {
6-
(event: React.FormEvent<HTMLFormElement>, store: FormStore): void | Promise<any> | FormError | string;
6+
(event: React.FormEvent<HTMLFormElement>, store: FormStore): void | Promise<never> | FormError | string;
77
}

0 commit comments

Comments
 (0)