fixes card Type never possibly matching for openprinttag #3
Conversation
|
Nice catch! Thanks! Curious to hear what you are using/will use the NFC agent for? This being our first PR, and not expecting much non-SimplyPrint-use of this (and as SimplyPrint doesn't actually use the "read content from tag" feature of this application yet, figured this wasn't coming from a concerned SP user) |
|
@AlbertMN You're right - not a SimplyPrint user (although it looks slick). I've been tinkering with OpenPrintTag for fun. I went down a rabbit hole trying to make a PN5180 work well with an ESP32 or even SBC, and the OSS library support for ISO15693 tags is all pretty limited/dated/completely broken. I'm not in a position where I can tackle rolling my own / fixing what exists, so I stumbled across this and thought I would give it a shot - it's great! I haven't been able to successfully write out OpenPrintTags yet, but I wanted to rule out user error before filing a bug (and ideally a PR to fix, if possible). |
|
Cool! Thanks for sharing, @hanzov69 Do report potential OpenPrintTag-related issues. The repo is new, we use it for beta testing the Filament Manager v2 update in SimplyPrint that launched silently a few days ago, with a proper launch planned for in a week's time or so, from which point the plan is that this repo should be a little more "production-friendly". I can confirm that via SimplyPrint, using the NFC Agent method, OpenPrintTag writing works, but we handle the CBOR stuff and all that in our API rather than using the built-in OpenPrintTag "easy-1-click" solution via this repo (just made for people like you!) - so the chances of that being broken are higher than much of the other stuff. Do keep the issues and PR's coming if you find anything - great to have some help on this project! My first GO project - ever. |
2 participants
fixes #2