Add License capabilities #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed additional unit tests.
…p.Selections.Api into License-feature
…p.Selections.Api into License-feature
+ Made LicenseZipParser less memory greedy and added additional logging + Ensured consistent contract resolver accessibility & fixed namespace format + Modified LicenseService to be in line with other new services ensuring observability and consistent messaging + Enabled flexible access to Licenses for Admin UI with filtering + Fixed bug where merging users didn't retain Country + Harmonized Licenses API interface + Added new File model to represent File results for the API Client + Adjusted Client code to match new harmonized API interface + Simplified LicenseRepository for better flexibility and added missing eager loading functionality + Fixed style issue with internal members of User + Added manual test for downloading application data - Removed TitleService adjustments - Removed BaseRepository adjustments - Removed TitleRepository adjustments - Removed LicenseServiceTests which did not follow testing patterns
# Conflicts: # azure-pipelines.yml # src/Mvp.Selections.Client/Mvp.Selections.Client.nuspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #79
Additions
Removals