Updated AWSSDK.S3 to 4.0 #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

mdupras wants to merge 2 commits into SixLabors:main from mdupras:mdupras/aws-sdk-4.0

Closed

Updated AWSSDK.S3 to 4.0 #385

This is to Match v3 behavior

Annotations

1 error and 10 warnings

Process completed with exit code 1.

tests/ImageSharp.Web.Benchmarks/Caching/CacheKeyBenchmarks.cs#L36

Member 'CreateUsingUriAbsoluteCacheKey' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

tests/ImageSharp.Web.Benchmarks/Caching/CacheKeyBenchmarks.cs#L30

Member 'CreateUsingUriRelativeCacheKey' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

tests/ImageSharp.Web.Benchmarks/Caching/CacheKeyBenchmarks.cs#L39

Member 'CreateUsingUriAbsoluteLowerInvariantCacheKey' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

tests/ImageSharp.Web.Benchmarks/Caching/CacheKeyBenchmarks.cs#L33

Member 'CreateUsingUriRelativeLowerInvariantCacheKey' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

tests/ImageSharp.Web.Benchmarks/Caching/ToHexBenchmarks.cs#L31

Member 'CustomToHex' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

tests/ImageSharp.Web.Benchmarks/Caching/CacheKeyBenchmarks.cs#L27

Member 'CreateUsingBaseline' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

tests/ImageSharp.Web.Benchmarks/Caching/ToHexBenchmarks.cs#L55

Member 'CustomToHexUnsafe' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

tests/ImageSharp.Web.Benchmarks/Caching/ToHexBenchmarks.cs#L18

Member 'StringBuilderToHex' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

tests/ImageSharp.Web.Benchmarks/Caching/ToHexBenchmarks.cs#L24

The behavior of 'byte.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'ToHexBenchmarks.StringBuilderToHex()' with a call to 'byte.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

tests/ImageSharp.Web.Benchmarks/Synchronization/AsyncLockBenchmarks.cs#L14

Type 'AsyncLockBenchmarks' owns disposable field(s) 'asyncKeyLock', 'asyncLock' but is not disposable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1001)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Updated AWSSDK.S3 to 4.0 #385

Uh oh!

Uh oh!

Updated AWSSDK.S3 to 4.0 #385

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...