Merge pull request #15 from stefannikolei/sn/editorconfig

Sync editorconfig

Author: JimBobSquarePants

.editorconfig

@@ -161,6 +161,9 @@ csharp_style_deconstructed_variable_declaration = true:warning
 csharp_style_prefer_index_operator = true:warning
 csharp_style_prefer_range_operator = true:warning
 csharp_style_implicit_object_creation_when_type_is_apparent = true:error
+# ReSharper inspection severities
+resharper_arrange_object_creation_when_type_evident_highlighting = error
+resharper_arrange_object_creation_when_type_not_evident_highlighting = error
 # "Null" checking preferences
 csharp_style_throw_expression = true:warning
 csharp_style_conditional_delegate_call = true:warning
@@ -174,6 +177,11 @@ csharp_using_directive_placement = outside_namespace:warning
 csharp_prefer_static_local_function = true:warning
 # Primary constructor preferences
 csharp_style_prefer_primary_constructors = false:none
+# Collection preferences
+dotnet_style_prefer_collection_expression = true:error
+resharper_use_collection_expression_highlighting =true:error
+
+
 
 ##########################################
 # Unnecessary Code Rules

src/PolygonClipper/PolygonClipper.cs

@@ -253,7 +253,7 @@ private static bool TryTrivialOperationForEmptyPolygons(
         {
             if (operation == BooleanOperation.Intersection)
             {
-                result = new();
+                result = new Polygon();
                 return true;
             }
 
@@ -302,7 +302,7 @@ private static bool TryTrivialOperationForNonOverlappingBoundingBoxes(
         {
             if (operation == BooleanOperation.Intersection)
             {
-                result = new();
+                result = new Polygon();
                 return true;
             }
 
@@ -843,7 +843,7 @@ private static Polygon ConnectEdges(List<SweepEvent> sortedEvents, SweepEventCom
 
     private static ReadOnlySpan<int> PrecomputeIterationOrder(List<SweepEvent> data)
     {
-        Span<int> map = new Span<int>(new int[data.Count]);
+        Span<int> map = new(new int[data.Count]);
 
         int i = 0;
         while (i < data.Count)

tests/GeoJson/Converters/CrsConverter.cs

@@ -70,7 +70,7 @@ public override object Read(
                 {
                     string? name = properties.GetProperty("name").GetString();
 
-                    NamedCRS? target = new NamedCRS(name);
+                    NamedCRS? target = new(name);
                     NamedCRS? converted = jObject.Deserialize<NamedCRS>();
 
                     if (converted.Properties != null)
@@ -90,7 +90,7 @@ public override object Read(
                 {
                     string? href = properties.GetProperty("href").GetString();
 
-                    LinkedCRS? target = new LinkedCRS(href);
+                    LinkedCRS? target = new(href);
 
                     LinkedCRS? converted = jObject.Deserialize<LinkedCRS>();
 

tests/GeoJson/Converters/FeatureConverter.cs

@@ -15,7 +15,7 @@ namespace GeoJSON.Text.Converters
     /// </summary>
     public class FeatureConverter : JsonConverter<object>
     {
-        private static readonly GeometryConverter geometryConverter = new GeometryConverter();
+        private static readonly GeometryConverter geometryConverter = new();
         /// <summary>
         ///     Determines whether this instance can convert the specified object type.
         /// </summary>

tests/GeoJson/Converters/GeometryEnumerableConverter.cs

@@ -14,7 +14,7 @@ namespace GeoJSON.Text.Converters
     /// </summary>
     public class GeometryEnumerableConverter : JsonConverter<ReadOnlyCollection<IGeometryObject>>
     {
-        private static readonly GeometryConverter GeometryConverter = new GeometryConverter();
+        private static readonly GeometryConverter GeometryConverter = new();
 
         /// <summary>
         ///     Determines whether this instance can convert the specified object type.
@@ -52,7 +52,7 @@ public override ReadOnlyCollection<IGeometryObject> Read(
             }
 
             int startDepth = reader.CurrentDepth;
-            List<IGeometryObject>? result = new List<IGeometryObject>();
+            List<IGeometryObject>? result = new();
             while (reader.Read())
             {
                 if (JsonTokenType.EndArray == reader.TokenType && reader.CurrentDepth == startDepth)
@@ -90,4 +90,4 @@ public override void Write(
             writer.WriteEndArray();
         }
     }
-}
+}

tests/GeoJson/Converters/LineStringEnumerableConverter.cs

@@ -14,7 +14,7 @@ namespace GeoJSON.Text.Converters
     /// </summary>
     public class LineStringEnumerableConverter : JsonConverter<IReadOnlyCollection<LineString>>
     {
-        private static readonly PositionEnumerableConverter LineStringConverter = new PositionEnumerableConverter();
+        private static readonly PositionEnumerableConverter LineStringConverter = new();
 
         /// <summary>
         /// Determines whether this instance can convert the specified object type.
@@ -54,7 +54,7 @@ public override IReadOnlyCollection<LineString> Read(
             }
 
             int startDepth = reader.CurrentDepth;
-            List<LineString>? result = new List<LineString>();
+            List<LineString>? result = new();
             while (reader.Read())
             {
                 if(JsonTokenType.EndArray == reader.TokenType && reader.CurrentDepth == startDepth)

tests/GeoJson/Converters/PointEnumerableConverter.cs

@@ -14,7 +14,7 @@ namespace GeoJSON.Text.Converters
     /// </summary>
     public class PointEnumerableConverter : JsonConverter<ReadOnlyCollection<Point>>
     {
-        private static readonly PositionConverter PositionConverter = new PositionConverter();
+        private static readonly PositionConverter PositionConverter = new();
         /// <inheritdoc />
         public override void Write(
             Utf8JsonWriter writer,
@@ -47,8 +47,8 @@ public override ReadOnlyCollection<Point> Read(
             }
 
             int startDepth = reader.CurrentDepth;
-            List<Point>? result = new List<Point>();
-            List<double> numbers = new List<double>();
+            List<Point>? result = new();
+            List<double> numbers = new();
             while (reader.Read())
             {
                 if (JsonTokenType.EndArray == reader.TokenType && reader.CurrentDepth == startDepth)

tests/GeoJson/Converters/PolygonEnumerableConverter.cs

@@ -18,7 +18,7 @@ namespace GeoJSON.Text.Converters
     public class PolygonEnumerableConverter : JsonConverter<IReadOnlyCollection<Polygon>>
     {
 
-        private static readonly LineStringEnumerableConverter PolygonConverter = new LineStringEnumerableConverter();
+        private static readonly LineStringEnumerableConverter PolygonConverter = new();
         /// <summary>
         ///     Determines whether this instance can convert the specified object type.
         /// </summary>
@@ -58,7 +58,7 @@ public override IReadOnlyCollection<Polygon> Read(
             }
 
             int startDepth = reader.CurrentDepth;
-            List<Polygon>? result = new List<Polygon>();
+            List<Polygon>? result = new();
             while (reader.Read())
             {
                 if (JsonTokenType.EndArray == reader.TokenType && reader.CurrentDepth == startDepth)

tests/GeoJson/Converters/PositionEnumerableConverter.cs

@@ -54,7 +54,7 @@ public override IReadOnlyCollection<IPosition> Read(
             }
 
             int startDepth = reader.CurrentDepth;
-            List<IPosition>? result = new List<IPosition>();
+            List<IPosition>? result = new();
             while (reader.Read())
             {
                 if (JsonTokenType.EndArray == reader.TokenType && reader.CurrentDepth == startDepth)

tests/GeoJson/CoordinateReferenceSystem/DefaultCRS.cs

@@ -28,6 +28,6 @@ private DefaultCRS()
         /// <value>
         /// The instance.
         /// </value>
-        public static DefaultCRS Instance { get; } = new DefaultCRS();
+        public static DefaultCRS Instance { get; } = new();
     }
 }