Skip to content

Conversation

@ShallowGreen
Copy link

@ShallowGreen ShallowGreen commented Mar 26, 2021

Pre-flight checklist

  • Unit tests for all non-trivial changes
  • Tested locally

@SkalskiP
Copy link
Owner

Hi @ShallowGreen, thank you for submitting your PR. Works well for rects. Would you be kind enough to add that functionality for lines and polygons? If not then we will just merge it ;) And I'll support it sometime in future.

@ShallowGreen
Copy link
Author

Hi @ShallowGreen, thank you for submitting your PR. Works well for rects. Would you be kind enough to add that functionality for lines and polygons? If not then we will just merge it ;) And I'll support it sometime in future.

Sorry for taking so long to reply, there will no new functionality for lines and polygons for short time. :)

@SkalskiP
Copy link
Owner

Hi @ShallowGreen, thank you for submitting your PR. Works well for rects. Would you be kind enough to add that functionality for lines and polygons? If not then we will just merge it ;) And I'll support it sometime in future.

Sorry for taking so long to reply, there will no new functionality for lines and polygons for short time. :)

Hi 👋 @ShallowGreen, now it has taken me a long time to respond. In this situation we will merge your change in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants