Conversation
rmobis
force-pushed
the
rmobis/new-transports
branch
10 times, most recently
from
ef1b6ae to
81d6b18
Compare
| 1422 2963 0 1923 5709 0 Home Portal 55353 35 Construction 2187=9 4 Home Portal | ||
|
|
||
| # Myths' Guild Portals | ||
| 2456 2855 2 2904 3512 0 Enter Portal of Heroes 31621 6104=215 1 Heroes' Guild |
There was a problem hiding this comment.
Is using this Varbit correct? Should it rather be a quest requirement on "Dragon Slayer II". I am not sure what exactly the DS2 varbit corresponds to.
There was a problem hiding this comment.
It should be a quest requirement, but I couldn't find a column for that in that file, so I had to improvise. I can't say I'm 100% sure, but I believe the DS2 varbit is used to keep track of progress in Dragon Slayer II and 215 should be the value when you have it completed.
If we can do the actual quest requirement that would be better, yes.
There was a problem hiding this comment.
See above, Temple of the Eye uses a quest requirement, I think you could do that.
There was a problem hiding this comment.
Not sure how I missed that. It's been fixed now.
| 3246 9646 0 3313 9613 0 Mines Dartog 7301 Death to the Dorgeshuun 8 Mines | ||
| 3246 9646 0 3232 9610 0 Cellar Dartog 997 Death to the Dorgeshuun 8 Cellar | ||
|
|
||
| # Elemental Workshop (you don't actually need to complete the quest, but I don't know which VarBit to check) |
There was a problem hiding this comment.
It might be 13718, I can check when I do the quest.
|
I went through and checked the different varbits/itemIDs look sensible. 👍 It would be nice if you could just write the names rather than numeric identifiers! |
|
Preview of the new coordinates: mpickering#9 (comment) I wonder if the coordinates for the mines transport are slightly wrong? |
They seem to be correct, I even tested a few paths back then. 
|
rmobis
force-pushed
the
rmobis/new-transports
branch
from
671009f to
abbab5c
Compare
This is possible for some items, but they have to be listed in ItemVariations.java (it's a side product of that functionality). Looks good @rmobis ! Do you have anything else you wanted to add (as your last commit was two days ago), or can I start reviewing and merging? |
@FIrgolitsch Feel free to review. I have some other stuff I want to work on, but I'll create a separate branch and PR for those in the future. |
|
Alright! I'll have an in-depth look sometime this weekend! |
rmobis
force-pushed
the
rmobis/new-transports
branch
from
abbab5c to
70df11b
Compare
|
I've updated the PR to resolve the conflicts |
3 participants
This PR includes a few new transports from the long list I collect of missing transports:
Cook's GuildtoCooking Guildin Skills Necklace, as that's the in-game name for the teleport option