Fix parsing of house portal teleports#389
Open
mpickering wants to merge 2 commits intoSkretzo:masterfrom
Open
Conversation
This makes it much easier to identify why a particular transport is
failing to parse. For example, rather than:
> Invalid item or quantity: 10CONSTRUCTION
we now see
> 2026-03-22 09:10:20 GMT [Test worker] ERROR shortestpath.transport.Transport - Invalid item or quantity: 35CONSTRUCTION fieldMap={Origin=1422 2963 0, Destination=1923 5709 0, menuOption menuTarget objectID=Home Portal 55353, VarPlayers=, Quests=, Display info=Home Portal, Items=35 Construction, Duration=4, Varbits=2187=9}
Which indicates clearly that the issue is with home portals.
* The varbits for house location are sufficient to check where the house teleport will go. * The possession of the construction cape is necessary to use the construction cape, which is a consequence of 99 construction. Fixes Skretzo#387
Collaborator
|
Good point. That seems a bit double. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix removes the level requirements from teleports which are already guarded by using the correct varbits for house location.
Fixes #387