Skip to content

Add multiple transports#391

Open
Blonks-afk wants to merge 4 commits intoSkretzo:masterfrom
Blonks-afk:add-multiple-transports
Open

Add multiple transports#391
Blonks-afk wants to merge 4 commits intoSkretzo:masterfrom
Blonks-afk:add-multiple-transports

Conversation

@Blonks-afk
Copy link
Copy Markdown

Add the boat that travels from Pisc Fishing Colony down to the river west of Gnome Stronghold.
Add the buildable agility shortcut between mainland Mory (west of Fenkenstrain's Castle) and the Mausoleum island.

Please let me know if the Ring of Charos formatting is incorrect and I can fix it

Add the boat run by Kathy Corkat that goes from Pisc to West of Gnome Stronghold
Update the boat duration for Kathy Corkat to 10 ticks
Add the buildable bridge west of Fenkenstrains Castle that goes to the Mausoleum
Fix formatting
@mpickering
Copy link
Copy Markdown

Coordinate preview: mpickering#5 (comment)

Copy link
Copy Markdown
Collaborator

@FIrgolitsch FIrgolitsch Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quest goes into a separate column of the TSV file, the next one after item in this file.

The item requirements can actually be merged in a single line. The tsv files suport & and | operators for the item requirements: https://github.com/Skretzo/shortest-path/blob/master/docs/Transport-TSV-format.md#items

Right now this transport would always work whenever you have completed the quest (without any of the items), have 50 coins in your inventory (with the quest incomplete) or the same for the ring.

For the ring I would just use the ID of the activated version. It's not listed in the ItemVariations.java file, so the canonical name won't be picked up.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah darn, I may have messed up the editor config in Intellij for tsv files. I'll fix up the formatting and update with this feedback.

Right now this transport would always work whenever you have completed the quest (without any of the items), have 50 coins in your inventory (with the quest incomplete) or the same for the ring.

Okay, that looks like what I was trying to do. If I'm understanding things correctly, it'd still need to be 2 lines then, one for no item requirements post-quest, and the other would be COINS=50||6465=1, correct?

Copy link
Copy Markdown
Collaborator

@FIrgolitsch FIrgolitsch Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to check the varbits for that quest. If you look at the minecarts.tsv they have a similar situation for the Lovakngj minecrats which will become free after a certain point in the Forsaken Tower quest. You would indeed still need two lines. The || operator is correct like this!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to check the varbits for that quest. If you look at the minecarts.tsv they have a similar situation for the Lovakngj minecrats which will become free after a certain point in the Forsaken Tower quest. You would indeed still need two lines. The || operator is correct like this!

I just tested it out on my alt since it's not fully progressed through Swan Song either, but it turns out Kathy is able to take payment straight from the bank. Is there any precedent for an item requirement that does not explicitly need to be on your person? I know there's the plugin config options to use Inventory vs Bank, but to me that's not quite the same thing since that would include other teleport items that aren't usable unless you actually have them

2547 3744 0 2547 3749 0 Climb Rocks 53254 85 Agility 5
3500 9510 2 3506 9505 2 Squeeze-through Crevice 16465 86 Agility
3506 9505 2 3500 9510 2 Squeeze-through Crevice 16465 86 Agility
3504 3559 0 3504 3562 0 Cross Bridge 57717 69 Agility 4441=2;5023=2 4
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to verify the varbits here. Do you happen to have a reference?

Copy link
Copy Markdown
Author

@Blonks-afk Blonks-afk Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly do. Here's the runelite gamevals that I pulled it from.

4441 (FENK_BUILT_BRIDGE_NORTH)

5023 (FENK_BUILT_BRIDGE_SOUTH)

I don't have any alts that are able to build it but haven't to verify that it's updated when that Mausoleum bridge is built, but I did test the changes between both my main and alt (one has it built, the other doesn't) and it correctly determined what path to take based on whether I could use that shortcut or not. I'll see how much work it would take to complete it on my alt and track the varbit in the RuneLite shell though, just to absolutely confirm that those gamevals are referring to that shortcut bridge.

I'm pretty confident in it though, since those varbits were added to the cache in the same update that the shortcut came out (see wiki cache diff here)

Copy link
Copy Markdown
Collaborator

@FIrgolitsch FIrgolitsch Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly do. Here's the runelite gamevals that I pulled it from.

Do you have the values as well? I'm trying to figure out if it should be 1 or 2.
I know some use 1 for partially built and then 2 for fully built, but some use 1 for just built as well. If it's working for your main it should be fine though.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My alt had the quest done, I just hadn't built it. Got a few construction levels to build it and here's the changes in the varbits:

On a level 3 alt (no quest, no bridge), both the north and south varbits were 0. On my alt that had the quest but hadn't built it, they were both 1. The north and south varbits changed to 2 when I built the corresponding side of the bridge, so I'm 100% certain now that it's those two with a value of 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants