Centralize transport type configuration#401
Open
FIrgolitsch wants to merge 2 commits intoSkretzo:masterfrom
Open
Centralize transport type configuration#401FIrgolitsch wants to merge 2 commits intoSkretzo:masterfrom
FIrgolitsch wants to merge 2 commits intoSkretzo:masterfrom
Conversation
- Add parser package: TsvParser, TransportRecord, FieldParser, WorldPointParser, SkillRequirementParser, ItemRequirementParser, QuestParser, VarCheckType, VarRequirement, VarRequirementParser - Add requirement package: ItemRequirement, TransportItems - Remove old model classes: TransportVarCheck, TransportVarbit, TransportVarPlayer, TransportItems (old) - Update Transport.java with builder pattern and TransportRecord constructor - Update TransportType with resourcePath, radiusThreshold, isTeleport() instance method, refine() - Update TransportLoader to use TsvParser - Update PathfinderConfig to use VarRequirement and ItemRequirement - Update overlays for isTeleport() instance method - Update all tests for new types
- Add TransportTypeConfig to manage enabled/cost state per TransportType - Add enabledGetter and costGetter functional fields to TransportType - Add override(TransportType, ...) convenience methods to ShortestPathPlugin - Replace individual boolean fields and if-else chain in PathfinderConfig.useTransport() with TransportTypeConfig lookups - Extract checkPohVariant, checkTeleportationItemRules, checkJewelleryBoxTier, remapPohTransports helper methods - Remove artificialTransportCosts EnumMap (costs from config via costGetter) - Remove testTeleportationBoxes (now gated by useTeleportationItems) - Add TransportTypeConfigTest
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize per-transport-type configuration (enabled state, cost) into a single
TransportTypeConfigclass, replacing scattered boolean/int fields inPathfinderConfig.Depends on: #329 (Transport Parsing Refactor)
Changes
TransportTypeConfig.java: Centralized per-type enabled/cost configuration withTransportTypeConfigTestTransportType.java: AddedenabledGetter()andcostGetter()methods to link each type to its config accessorShortestPathPlugin.java: Override methods for transport type enabled/cost settingsPathfinderConfig.java: Replaced individual boolean/int fields (useAgilityShortcuts,costFairyRings, etc.) with a singleTransportTypeConfiginstance6 files changed (on top of #329), +907/−359