Implement proper Opml import - and do some cleanup in the SubscriptioptionManager#1395
Merged
gzsombor merged 2 commits intoSkyTubeTeam:masterfrom Jan 26, 2026
Merged
Implement proper Opml import - and do some cleanup in the SubscriptioptionManager#1395gzsombor merged 2 commits intoSkyTubeTeam:masterfrom
gzsombor merged 2 commits intoSkyTubeTeam:masterfrom
Conversation
…nManager Better labels
There was a problem hiding this comment.
Pull request overview
This PR implements proper OPML import functionality for YouTube subscriptions and refactors the SubscriptionsBackupsManager to improve code organization and maintainability.
Changes:
- Added a dedicated
OpmlParserclass with comprehensive test coverage for parsing OPML files - Refactored
SubscriptionsBackupsManagerto extract duplicate callback logic and simplify threading management - Added UI elements and strings to support OPML import functionality in the backup preferences
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| OpmlParser.java | New parser implementation for OPML files with support for various YouTube URL formats |
| OpmlParserTest.java | Comprehensive test suite for OPML parser covering basic parsing, folders, parameters, and edge cases |
| SubscriptionsBackupsManager.java | Refactored to use new OpmlParser, extracted UriReceivedCallback class, simplified threading logic |
| OpmlExporterTest.java | Added test to verify exported OPML can be parsed back |
| OpmlExporter.java | Removed unused imports |
| preference_backup.xml | Added OPML import preference UI element |
| strings_preferences.xml | Added strings for OPML import feature |
| strings_subs.xml | Updated error message text |
| BackupPreferenceFragment.java | Added click handler for OPML import preference |
| app/build.gradle | Added XML Pull Parser test dependency |
| basic.opml, empty.opml, missing_attrs.opml, user_urls.opml, with_folders.opml, with_params.opml | Test resource files for OPML parsing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/test/java/free/rm/skytube/businessobjects/opml/OpmlParserTest.java
Outdated
Show resolved
Hide resolved
app/src/main/java/free/rm/skytube/businessobjects/opml/OpmlParser.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.