You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request refactors the CalendarDayCellTestTag enum by moving it from an internal scope to a dedicated file and updates its usage accordingly. This change improves code organization and reusability.
Code Organization:
Created a new file, CalendarDayCellTestTag.kt, and moved the CalendarDayCellTestTag enum to this file to make it more modular and accessible.
Removed the inline definition of CalendarDayCellTestTag from BpkCalendarDayCell.kt and replaced it with an import statement referencing the new file. [1][2]
These new files do not include the license heading: backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/calendar/CalendarDayCellTestTag.kt
Warnings
⚠️
One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️
One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.
⚠️
One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️
One or more package files were created, but BpkComposeComponentUsageDetector.kt wasn't updated. If your component is an equivalent of a core component please add it to the detector.
These new files do not include the license heading: backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/calendar/BpkCalendarDayCellTestTag.kt
Warnings
⚠️
One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️
One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.
⚠️
One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️
One or more package files were created, but BpkComposeComponentUsageDetector.kt wasn't updated. If your component is an equivalent of a core component please add it to the detector.
One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️
One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.
⚠️
One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️
One or more package files were created, but BpkComposeComponentUsageDetector.kt wasn't updated. If your component is an equivalent of a core component please add it to the detector.
One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️
One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.
⚠️
One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️
One or more package files were created, but BpkComposeComponentUsageDetector.kt wasn't updated. If your component is an equivalent of a core component please add it to the detector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minorA new & backwards compatible feature/component
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
CalendarDayCellTestTagenum by moving it from an internal scope to a dedicated file and updates its usage accordingly. This change improves code organization and reusability.Code Organization:
CalendarDayCellTestTag.kt, and moved theCalendarDayCellTestTagenum to this file to make it more modular and accessible.CalendarDayCellTestTagfromBpkCalendarDayCell.ktand replaced it with an import statement referencing the new file. [1] [2]Remember to include the following changes:
README.mdIf you are curious about how we review, please read through the code review guidelines