Skip to content

[DON-1368] move CalendarDayCellTestTag#2270

Merged
peterliu (peterInTown) merged 4 commits intomainfrom
DON-1368-move-calendar-day-test-tag
Apr 23, 2025
Merged

[DON-1368] move CalendarDayCellTestTag#2270
peterliu (peterInTown) merged 4 commits intomainfrom
DON-1368-move-calendar-day-test-tag

Conversation

@peterInTown
Copy link
Contributor

@peterInTown peterliu (peterInTown) commented Apr 23, 2025

This pull request refactors the CalendarDayCellTestTag enum by moving it from an internal scope to a dedicated file and updates its usage accordingly. This change improves code organization and reusability.

Code Organization:

  • Created a new file, CalendarDayCellTestTag.kt, and moved the CalendarDayCellTestTag enum to this file to make it more modular and accessible.
  • Removed the inline definition of CalendarDayCellTestTag from BpkCalendarDayCell.kt and replaced it with an import statement referencing the new file. [1] [2]

Remember to include the following changes:

  • Component README.md
  • Tests

If you are curious about how we review, please read through the code review guidelines

@skyscanner-backpack-bot
Copy link
Contributor

Fails
🚫 These new files do not include the license heading: backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/calendar/CalendarDayCellTestTag.kt
Warnings
⚠️ One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️

One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.

⚠️

One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

⚠️

One or more package files were created, but BpkComposeComponentUsageDetector.kt wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 2df43f2

@peterInTown peterliu (peterInTown) added the minor A new & backwards compatible feature/component label Apr 23, 2025
@skyscanner-backpack-bot
Copy link
Contributor

Fails
🚫 These new files do not include the license heading: backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/calendar/BpkCalendarDayCellTestTag.kt
Warnings
⚠️ One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️

One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.

⚠️

One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

⚠️

One or more package files were created, but BpkComposeComponentUsageDetector.kt wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against df50c36

@skyscanner-backpack-bot
Copy link
Contributor

Warnings
⚠️ One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️

One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.

⚠️

One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

⚠️

One or more package files were created, but BpkComposeComponentUsageDetector.kt wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against a5866d2

@skyscanner-backpack-bot
Copy link
Contributor

Warnings
⚠️ One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️

One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via ./gradlew recordScreenshots.

⚠️

One or more component files were updated, but README.md wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.

⚠️

One or more package files were created, but BpkComposeComponentUsageDetector.kt wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 7ce314c

@peterInTown peterliu (peterInTown) merged commit 4a6fd7d into main Apr 23, 2025
7 checks passed
@peterInTown peterliu (peterInTown) deleted the DON-1368-move-calendar-day-test-tag branch April 23, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor A new & backwards compatible feature/component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants