-
Notifications
You must be signed in to change notification settings - Fork 34
fix: replace shell command substitution with GitHub Actions env variables in copyright workflow #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ables instead of shell substitution Co-authored-by: peterInTown <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the copyright update workflow by replacing shell command substitution with GitHub Actions environment variables. The workflow was failing because $(date +%Y) was being interpreted as a literal string in YAML parameters instead of being executed, resulting in an invalid branch name.
Key changes:
- Added a step to set the
YEARenvironment variable using$GITHUB_ENV - Replaced all
$(date +%Y)shell substitutions with GitHub Actions expression${{ env.YEAR }}
|
Copilot change the runner to runs-on: ubuntu-24.04-16cores-public |
…creation and app token management
…epository checkout
The copyright update workflow failed because
$(date +%Y)shell substitution in YAML parameters was treated as a literal string, creating an invalid branch namecopyright-year-update-$(date +%Y).Changes
YEARenvironment variable using$GITHUB_OUTPUT$(date +%Y)references with${{ steps.date.outputs.year }}in:peter-evans/create-pull-requestactionubuntu-24.04-16cores-publicfor improved performanceShell commands only execute within
run:blocks; workflow parameters require GitHub Actions expressions.Remember to include the following changes:
README.md(N/A - workflow-only change)If you are curious about how we review, please read through the code review guidelines
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.