[DON-2163] Add explicit import for SPM support and avoid @_exported attribute #2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttribute Added conditional imports for BackpackTokens across multiple files to support Swift Package builds. Updated import statements from @_exported to standard imports for consistency and removed unnecessary Foundation imports in UIKit-based files. Also updated Package.swift to include BackpackTokens as a dependency for Backpack_SwiftUI.
Soheil Novinfard (novinfard)
changed the base branch from
donburi/DON-2163-add-spm-support-uikit-swift
to
main
Soheil Novinfard (novinfard)
changed the base branch from
main
to
donburi/DON-2163-add-spm-support-uikit-swift
faurevid
approved these changes
Nov 6, 2025
Base automatically changed from
donburi/DON-2163-add-spm-support-uikit-swift
to
main
November 6, 2025 16:07
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the experimental @_exported import attribute and adds explicit import statements across the codebase to improve Swift Package Manager (SPM) compatibility. The changes replace transitive imports with direct imports, ensuring modules explicitly declare their dependencies.
Key Changes:
- Removed
@_exportedattributes from central import files (BackpackUIKitImports.swift, BackpackSwiftUIImports.swift, BackpackCommonImports.swift) - Added conditional
#if SWIFT_PACKAGEimports for BackpackTokens where needed - Added explicit Foundation/UIKit imports to files that previously relied on transitive imports
- Updated Package.swift to declare BackpackTokens as a direct dependency of Backpack_SwiftUI
Reviewed Changes
Copilot reviewed 36 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Package.swift | Added BackpackTokens as an explicit dependency for Backpack_SwiftUI target |
| Backpack/BackpackUIKitImports.swift | Removed @_exported attributes, added conditional BackpackTokens import |
| Backpack-SwiftUI/BackpackSwiftUIImports.swift | Removed @_exported attributes from Foundation, SwiftUI, and UIKit imports |
| Backpack-Common/BackpackCommonImports.swift | Removed @_exported attributes from Foundation and UIKit imports |
| Multiple Skeleton classes | Added conditional BackpackTokens imports for SPM builds |
| Multiple BottomSheet classes | Added UIKit and conditional BackpackTokens imports |
| Multiple Calendar classes | Added explicit Foundation imports |
| Multiple Button classes | Added conditional BackpackTokens imports |
| Carousel/PageViewController files | Changed Foundation imports to UIKit imports |
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
The import statement should use conditional compilation for SPM consistency. Consider adding #if SWIFT_PACKAGE wrapper around BackpackTokens import if BPKCarousel uses any token types, similar to other files in this PR.
Suggested change
| #if SWIFT_PACKAGE | |
| import BackpackTokens | |
| #endif |
| */ | ||
|
|
||
| // swiftlint:disable indentation_width | ||
| import UIKit |
There was a problem hiding this comment.
The UIKit import appears unnecessary for a SwiftUI component. SwiftUI color types don't require UIKit. Consider removing this import unless there's a specific UIKit dependency in the implementation.
Suggested change
| import UIKit |
Cleaned up unnecessary import statements in generated color and icon files to reduce clutter and improve code clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON-2163 Add explicit import for SPM support and avoid @_exported attribute
This PR adds explicit import statements across multiple files to improve compatibility with Swift Package Manager (SPM) builds. It replaces the experimental @_exported import attribute with standard imports for better maintainability and consistency.