Fix: Player Observer callback types and removed inflight#11
Open
EstebenR wants to merge 3 commits intoSleitnick:mainfrom
Open
Fix: Player Observer callback types and removed inflight#11EstebenR wants to merge 3 commits intoSleitnick:mainfrom
EstebenR wants to merge 3 commits intoSleitnick:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback type of
Enum.PlayerExitReasonwas missing, giving an errorI also removed references to inflight which wasn't getting used. It was only used on initial connection to call cleanup with
Enum.PlayerExitReason.Unknownin case the player had left and then set to nil.Setting to nil on connection also meant that if you disconnected the observer, the callback would be called with
nil, giving an error if you tried to access it. Made it so that on manual disconnection of observer the cleanup is called withPlayerExitReason.Unknown