COMP: Fix unused parameter warnings in vtkParallelTransportTest1.cxx
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unused parameter warnings in `vtkParallelTransportTest1.cxx`:
- Remove the unused `lineDirection` variable.
- Make use of the `tangentsArray` variable by querying its contents
using the index and print them.
Fixes:
```
/usr/src/Slicer-build/vtkAddon/Testing/vtkParallelTransportTest1.cxx:
In function ‘int vtkParallelTransportTest1(int, char**)’:
/usr/src/Slicer-build/vtkAddon/Testing/vtkParallelTransportTest1.cxx:100:21:
warning: unused variable ‘tangentsArray’ [-Wunused-variable]
vtkDoubleArray* tangentsArray = vtkDoubleArray::SafeDownCast(pointData->GetArray("Tangents"));
^~~~~~~~~~~~~
/usr/src/Slicer-build/vtkAddon/Testing/vtkParallelTransportTest1.cxx:38:10:
warning: unused variable ‘lineDirection’ [-Wunused-variable]
double lineDirection[3] = { 0.0, 0.0, 1.0 };
^~~~~~~~~~~~~
```
https://github.com/Slicer/Slicer/actions/runs/6950843491/job/18911721210#step:4:2749
jcfr
force-pushed
the
FixUnusedParameterWarnings
branch
from
d980faf to
c7b9260
Compare
dzenanz
approved these changes
Nov 20, 2025
Member
|
@jcfr I guess we should merge this? |
jcfr
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unused parameter warnings in
vtkParallelTransportTest1.cxx:lineDirectionvariable.tangentsArrayvariable by querying its contents using the index and print them.Fixes:
https://github.com/Slicer/Slicer/actions/runs/6950843491/job/18911721210#step:4:2749