Skip to content

COMP: Update find python method. #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chir-set wants to merge 1 commit into from
Closed

COMP: Update find python method. #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CMake/vtkWrapPython.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#-----------------------------------------------------------------------------
cmake_minimum_required(VERSION 3.12)
#-----------------------------------------------------------------------------

#
# CMake implementation of the Wrap Python command.
#
Expand Down Expand Up @@ -189,7 +193,7 @@ if(VTK_WRAP_PYTHON_FIND_LIBS)
else()
set(_QUIET_LIBRARY "REQUIRED")
endif()
find_package(PythonLibs ${_QUIET_LIBRARY})
find_package(Python3 COMPONENTS Development ${_QUIET_LIBRARY})
Copy link
Contributor

@jamesobutler jamesobutler Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A heads up that the same type of change was proposed in the main Slicer project, but resulted in issues of it picking up the System python instead of Slicer's python. See Slicer/Slicer#8578 (comment)

Copy link
Author

@chir-set chir-set Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but resulted in issues

Ok, this cannot be a generalised solution then - it stems from an attempt to build VMTK. I'll use it in my local branch.

Thank you for the information.


# Use separate debug/optimized libraries if they are different.
if(PYTHON_DEBUG_LIBRARY)
Expand Down