Skip to content

Runtime #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
loucass003 merged 10 commits into from
Dec 18, 2025
Merged

Runtime #1678

loucass003 merged 10 commits into from
Dec 18, 2025

Conversation

@sctanf
Copy link
Member

@sctanf sctanf commented Dec 14, 2025 •
edited
Loading

@github-actions github-actions bot added Area: Application Protocol Related to communication with apps like the GUI, overlay, games Area: GUI Related to the GUI Area: Translation Improvements or additions to translations Area: Server Related to the server labels Dec 14, 2025
@sctanf
Copy link
Member Author

sctanf commented Dec 14, 2025

SlimeVR/SolarXR-Protocol#189
Not including gui changes yet

@sctanf
Copy link
Member Author

sctanf commented Dec 14, 2025

image image

@sctanf sctanf marked this pull request as ready for review December 14, 2025 03:18
@sctanf
Copy link
Member Author

sctanf commented Dec 14, 2025

changed conditions for battery voltage appearing:
Default: Hide battery level if runtime is available, does not show voltage
Dev mode: Always show battery level, only show voltage on extended view
More info: Always show battery level, show voltage on extended view and on table

@sctanf sctanf force-pushed the runtime branch 2 times, most recently from 9ff4123 to eefb743 Compare December 15, 2025 15:07
@loucass003
Copy link
Member

loucass003 commented Dec 18, 2025 •
edited
Loading

please make it so the percent can still be shown with a tooltip when hovering the battery icon

loucass003
loucass003 requested changes Dec 18, 2025
View reviewed changes
@loucass003
Copy link
Member

loucass003 commented Dec 18, 2025

Need solaxr update before merge

@loucass003
Copy link
Member

loucass003 commented Dec 18, 2025

Still conflicts

@loucass003 loucass003 merged commit b44dcaa into SlimeVR:main Dec 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loucass003 loucass003 loucass003 requested changes

@ButterscotchV ButterscotchV Awaiting requested review from ButterscotchV ButterscotchV is a code owner

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

Assignees

No one assigned

Labels

Area: Application Protocol Related to communication with apps like the GUI, overlay, games Area: GUI Related to the GUI Area: Server Related to the server Area: Translation Improvements or additions to translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sctanf @loucass003