Skip to content

Conversation

@alexsvorada
Copy link

@alexsvorada alexsvorada commented Mar 29, 2025

CustomItemStack from dough is no longer an ItemStack, but a helper class to create ItemStack.
suggested change: Change new CustomItemStack(...) to CustomItemStack.create(...). Most constructor parameters are kept in the same order.
SlimefunItemStack is no longer an ItemStack but a delegate of ItemStack.
to get the underlying ItemStack, use .item()
The ItemStack instanceof SlimefunItemStack no longer makes sense, use SlimefunItem.getByItem() to get the SlimefunItem instance.```

Fixed the issues caused by these changes

@alexsvorada
Copy link
Author

How should the backward compatibility be done?
Create static vars in ExoticGarden and wire the proper value based on the MinecraftVersion in onEnable?

@alexsvorada
Copy link
Author

Also can you help me understand why are we maintaning backward support for an enum that has been changed 4 major updates ago?

@alexsvorada alexsvorada requested a review from ybw0014 March 30, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants