Open
Conversation
Contributor
|
Your Pull Request was automatically labelled as: "✨ Fix" |
Contributor
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4271/9d621cf0
|
TheBusyBiscuit
requested changes
Jan 11, 2025
Member
TheBusyBiscuit
left a comment
TheBusyBiscuit
left a comment
There was a problem hiding this comment.
Nice quality-of-life improvement 👍🏻
...ava/io/github/thebusybiscuit/slimefun4/implementation/items/electric/machines/FluidPump.java
Outdated
Show resolved
Hide resolved
...ava/io/github/thebusybiscuit/slimefun4/implementation/handlers/MachineBlockBreakHandler.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Create a class extending SimpleBlockBreakHandler that handles inventories and MachineProcesoors (MachineBlockBreakHandler).
If the MachineProcessor is of CraftingOperation type and the process isn't completed, then the ingredients will be dropped.
Related Issues (if applicable)
Resolves #4268
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values