Remove old version when upgrading

Author: jantje

io.sloeber.core/src/io/sloeber/core/api/LibraryManager.java

@@ -142,7 +142,7 @@ public LibraryTree() {
 									.append(library.getArchitectures().toString()).append("\n\n") //$NON-NLS-1$
 									.append(library.getSentence());
 							lib = new Library(category, library.getName(), libraryIndex.getName(), builder.toString());
-							category.libraries.put(library.getName() + " (" + libraryIndex.getName() + ")", lib);  //$NON-NLS-1$//$NON-NLS-2$
+							category.libraries.put(library.getName() + " (" + libraryIndex.getName() + ")", lib); //$NON-NLS-1$//$NON-NLS-2$
 						}
 						lib.versions.add(new VersionNumber(library.getVersion()));
 						if (library.isInstalled()) {
@@ -219,10 +219,19 @@ public static String getPrivateLibraryPathsString() {
 		return InstancePreferences.getPrivateLibraryPathsString();
 	}
 
+	/**
+	 * Wrapper method for Manager. installAllLatestLibraries(String category)
+	 * 
+	 * @param category
+	 */
 	public static void installAllLatestLibraries(String category) {
 		Manager.installAllLatestLibraries(category);
 	}
 
+	/**
+	 * Convenience method for installAllLatestLibraries(String category) calling
+	 * it for all categories
+	 */
 	public static void installAllLatestLibraries() {
 		Set<String> allcategories = getAllCategories();
 		for (String categorieName : allcategories) {
@@ -231,6 +240,12 @@ public static void installAllLatestLibraries() {
 
 	}
 
+	/**
+	 * get all the categories for all libraries (installed or not)
+	 *
+	 * @return a list of all the categories that exist in any library json file
+	 *         known by sloeber
+	 */
 	public static Set<String> getAllCategories() {
 
 		Set<String> ret = new TreeSet<>();

io.sloeber.core/src/io/sloeber/core/managers/Manager.java

@@ -859,12 +859,23 @@ public static void onlyKeepLatestPlatforms() {
 		}
 	}
 
+	/**
+	 * Install the latest version of all the libraries belonging to this
+	 * category If a earlier version is installed this version will be removed
+	 * before installation of the newer version
+	 *
+	 * @param category
+	 */
 	public static void installAllLatestLibraries(String category) {
 		List<LibraryIndex> libraryIndices1 = getLibraryIndices();
 		for (LibraryIndex libraryIndex : libraryIndices1) {
 			Collection<Library> libraries = libraryIndex.getLatestLibraries(category);
 			for (Library library : libraries) {
 				if (!library.isInstalled()) {
+					Library previousVersion = libraryIndex.getInstalledLibrary(library.getName());
+					if (previousVersion != null) {
+						previousVersion.remove(new NullProgressMonitor());
+					}
 					library.install(new NullProgressMonitor());
 				}
 			}