added student profile model, student profile page, student profile views#5
Open
added student profile model, student profile page, student profile views#5
Conversation
GoldsteinE
reviewed
Jun 22, 2019
ennead/app.py
Outdated
| app.add_url_rule('/logout', 'logout', logout) | ||
|
|
||
| app.add_url_rule('/student_profile', 'read_student_profile', read_student_profile) | ||
| app.add_url_rule('/student_profile', 'create_student_profile', create_update_student_profile, methods=['POST', 'PUT']) |
Member
There was a problem hiding this comment.
PUT же мы в итоге решили, что не нужен?
ennead/app.py
Outdated
| app.add_url_rule('/logout', 'logout', logout) | ||
|
|
||
| app.add_url_rule('/student_profile', 'read_student_profile', read_student_profile) | ||
| app.add_url_rule('/student_profile', 'create_student_profile', create_update_student_profile, methods=['POST', 'PUT']) |
Member
There was a problem hiding this comment.
Suggested change
| app.add_url_rule('/student_profile', 'create_student_profile', create_update_student_profile, methods=['POST', 'PUT']) | |
| app.add_url_rule('/student_profile', 'create_student_profile', create_update_student_profile, methods=['POST']) |
ennead/models/student_profile.py
Outdated
|
|
||
| user: User = ForeignKeyField(User, backref='student_profiles') | ||
|
|
||
| def set_profile(self, request: Request, user: User = None) -> None: |
ennead/views/student_profile.py
Outdated
|
|
||
| student_profile = StudentProfile() | ||
|
|
||
| student_profile_query = StudentProfile.select().where(StudentProfile.user == g.user) |
…et in views to backref
GoldsteinE
reviewed
Jun 22, 2019
ennead/models/student_profile.py
Outdated
| from ennead.models.base import BaseModel | ||
| if TYPE_CHECKING: | ||
| # pylint: disable=R0401 | ||
| from ennead.models.thread import Thread # noqa: F401 |
ennead/views/student_profile.py
Outdated
| """GET /student_profile: read profile page""" | ||
|
|
||
| student_profile = None | ||
| try: |
Member
There was a problem hiding this comment.
Не-не-не.
if g.user.student_profiles:
student_profile = g.user.student_profiles[0]
else:
student_profile = StudentProfile()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.