fix: add role validation in reveal_attacker and reveal_defender#12
Closed
Slymeofthemonth wants to merge 1 commit intomainfrom
Closed
fix: add role validation in reveal_attacker and reveal_defender#12Slymeofthemonth wants to merge 1 commit intomainfrom
Slymeofthemonth wants to merge 1 commit intomainfrom
Conversation
Closes #4 - reveal_attacker now asserts caller has ROLE_ATK_A or ROLE_ATK_B - reveal_defender now asserts caller has ROLE_DEF_A or ROLE_DEF_B
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
Problem:
reveal_attackerandreveal_defenderdidn't verify the caller's role. Any player could call either function.Fix:
reveal_attackernow assertsrole == ROLE_ATK_A || role == ROLE_ATK_Breveal_defendernow assertsrole == ROLE_DEF_A || role == ROLE_DEF_BAll 18 existing tests pass.