This repository was archived by the owner on Dec 7, 2022. It is now read-only.
Feature: autodetect mime type on s3 driver - #163
Open
zamarawka wants to merge 6 commits into
Open
Conversation
Author
|
@RomainLanz bump |
Author
|
@RomainLanz Added handle copy/move actions and repair linter's config and usage. CI become partially alive. |
Author
|
@RomainLanz any way to merge it? I’d like to use it in my project. |
Author
|
@RomainLanz i still don't lose hope to merge it 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding autodetection of file's Content-type before uploading it to s3.
Without this I could't deliver files direct from aws s3 via s3-website. Files just download instead of viewing. This happend because of their content-type is
application/octet-streamBased on top of aws/aws-sdk-js#3085
Partially related with #125