Replaced deprecated tkinter trace methods with new versions#137
Replaced deprecated tkinter trace methods with new versions#137jstone-psi wants to merge 1 commit intoSmall-Bodies-Node:masterfrom
Conversation
|
Thank you for reporting and submitting a PR Jesse. This tool still supports Python 2.7 and 3.5 for now, so I think a bit more work is needed to do this in a compatible way (although support for 3.5 is likely to be dropped before the next release anyway). I can probably do that pretty quick when I have a moment. |
|
Understood. I was able to not break python 3.13 by checking for the presence of the trace_add function and branching based on that, but I'm not set up to test earlier versions of python. Hope this helps! |
|
As a note, Python 2.7 and 2.5 were EOL in 2020. Folks will clearly continue to run older versions of Python, but if that maintenance becomes too painful, an upgrade in system requirements, albeit painful for some, may help keep things moving forward. |
|
@jstone-psi If you give me write access on your fork, I can update it and merge. Alternatively I could close this PR, and open a separate PR based on this one. Edit: Feel free also to instead update your MR based on this version. |
|
@LevN0 Strangely, the option to allow writes that Github describes is not showing up for me. If you want me to merge your branch into mine and push it back up, I can certainly do that. |
|
I would say rebase/merge, squash and force push. Goal is to just leave a single clean commit in this PR that I can merge. |
Modified by: Lev Nagdimunov Replaced deprecated tkinter trace methods with new versions
7cd499c to
670d975
Compare
|
Ok, done. I had to resolve some merge conflicts, but I think I picked the correct resolutions. |
Fixes #136.
I've updated the tkinter code to use the new trace methods that were introduced in Python 3.6, which replace the deprecated versions that were recently removed.