Skip to content

Replaced deprecated tkinter trace methods with new versions#137

Open
jstone-psi wants to merge 1 commit intoSmall-Bodies-Node:masterfrom
sbn-psi:tkinter-deprecation-fixes
Open

Replaced deprecated tkinter trace methods with new versions#137
jstone-psi wants to merge 1 commit intoSmall-Bodies-Node:masterfrom
sbn-psi:tkinter-deprecation-fixes

Conversation

@jstone-psi
Copy link

Fixes #136.

I've updated the tkinter code to use the new trace methods that were introduced in Python 3.6, which replace the deprecated versions that were recently removed.

@LevN0
Copy link
Member

LevN0 commented Sep 18, 2025

Thank you for reporting and submitting a PR Jesse.

This tool still supports Python 2.7 and 3.5 for now, so I think a bit more work is needed to do this in a compatible way (although support for 3.5 is likely to be dropped before the next release anyway). I can probably do that pretty quick when I have a moment.

@jstone-psi
Copy link
Author

Understood. I was able to not break python 3.13 by checking for the presence of the trace_add function and branching based on that, but I'm not set up to test earlier versions of python. Hope this helps!

@jordanpadams
Copy link

As a note, Python 2.7 and 2.5 were EOL in 2020. Folks will clearly continue to run older versions of Python, but if that maintenance becomes too painful, an upgrade in system requirements, albeit painful for some, may help keep things moving forward.

@LevN0
Copy link
Member

LevN0 commented Feb 14, 2026

@jstone-psi If you give me write access on your fork, I can update it and merge. Alternatively I could close this PR, and open a separate PR based on this one.

Edit: Feel free also to instead update your MR based on this version.

@jstone-psi
Copy link
Author

@LevN0 Strangely, the option to allow writes that Github describes is not showing up for me.

If you want me to merge your branch into mine and push it back up, I can certainly do that.

@LevN0
Copy link
Member

LevN0 commented Feb 19, 2026

@jstone-psi

I would say rebase/merge, squash and force push. Goal is to just leave a single clean commit in this PR that I can merge.

Modified by: Lev Nagdimunov

Replaced deprecated tkinter trace methods with new versions
@jstone-psi jstone-psi force-pushed the tkinter-deprecation-fixes branch from 7cd499c to 670d975 Compare February 19, 2026 22:22
@jstone-psi
Copy link
Author

Ok, done. I had to resolve some merge conflicts, but I think I picked the correct resolutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PDS4 Viewer exceptions on Python 3.13+ due to removed trace methods in Tcl/Tk 9.0+

3 participants