Skip to content

Conversation

@daveylib-abb
Copy link

@daveylib-abb daveylib-abb commented Jun 13, 2025

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Introduction of the LUA driver.

Summary of Completed Tests

Manual tests have been done with all products that will be integrated via the WWST Certification Request.

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2025

CLA assistant check
All committers have signed the CLA.

@greens greens requested a review from cjswedes August 21, 2025 18:43
@greens
Copy link
Contributor

greens commented Aug 21, 2025

For my own ease of record-keeping:
WWSTCERT-7563
WWSTCERT-7566
WWSTCERT-7569
WWSTCERT-7572
WWSTCERT-7575
WWSTCERT-7578

@github-actions
Copy link

Duplicate profile check: Warning - duplicate profiles detected.
auxiliary-contact.yml == output-module.yml
current-sensor-consumption.yml == current-sensor-production.yml

@github-actions
Copy link

github-actions bot commented Aug 25, 2025

Channel deleted.

@github-actions
Copy link

github-actions bot commented Aug 25, 2025

Test Results

   72 files    480 suites   0s ⏱️
2 488 tests 2 488 ✅ 0 💤 0 ❌
4 270 runs  4 270 ✅ 0 💤 0 ❌

Results for commit 22ef9fb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 25, 2025

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 22ef9fb

@hcarter-775
Copy link
Contributor

@daveylib-abb can you rebase your branch on top of the latest of main? I am seeing some failing tests, probably due to some recent changes elsewhere that would require a rebase

@daveylib-abb daveylib-abb force-pushed the abb/scu200_insite_introduction branch 3 times, most recently from 63cbb1b to 08c1616 Compare September 1, 2025 11:34
@daveylib-abb
Copy link
Author

@hcarter-775, the branch has been rebased on top of the latest of main.

@hcarter-775
Copy link
Contributor

@daveylib-abb it appears that the luacheck is also failing. Would you mind checking and fixing these CI fails?

@hcarter-775
Copy link
Contributor

Hi @daveylib-abb
One more thing that should be changed before we merge this- could you move this driver out from under the */drivers/SmartThings/ parent directory and into a new one at the same level called */drivers/ABB/? Then perhaps the driver could be renamed scu200 if so desired, or could stay the same.

@daveylib-abb
Copy link
Author

@hcarter-775, I have fixed warnings coming out from the Luacheck linter tool, and I have moved the driver.

@greens greens force-pushed the abb/scu200_insite_introduction branch from 49fc265 to 22ef9fb Compare January 15, 2026 21:13
@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants