Matter Switch: Attempt re-profiling on device software updates #2466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 71 files 477 suites 0s ⏱️ Results for commit 1c77860. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1c77860 |
hcarter-775
commented
Oct 14, 2025
hcarter-775
commented
Oct 14, 2025
drivers/SmartThings/matter-switch/src/utils/device_configuration.lua
Outdated
Show resolved
Hide resolved
hcarter-775
force-pushed
the
switch-allow-reprofiling
branch
from
199f355 to
eda1721
Compare
greens
reviewed
Oct 23, 2025
drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua
Show resolved
Hide resolved
hcarter-775
commented
Oct 24, 2025
| end | ||
| end | ||
|
|
||
| function SwitchLifecycleHandlers.device_removed(driver, device) |
Contributor
Author
There was a problem hiding this comment.
I just moved this to the bottom of the file. We never touch this and I personally am always getting confused where device_init is when developing with this placed above it.
hcarter-775
force-pushed
the
update-metadata-switch
branch
2 times, most recently
from
fb3f845 to
73aa8dc
Compare
hcarter-775
force-pushed
the
switch-allow-reprofiling
branch
2 times, most recently
from
9daef3c to
2f1d29e
Compare
hcarter-775
force-pushed
the
switch-allow-reprofiling
branch
from
2f1d29e to
844dc8d
Compare
nickolas-deboom
approved these changes
Jan 6, 2026
Contributor
nickolas-deboom
left a comment
nickolas-deboom
left a comment
There was a problem hiding this comment.
I don't see any issues with these changes and think this will be a super handy feature. It would be good to see if we can test this on device and then this should be good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We store data related to the device software version (saved from the BasicInformation cluster's softwareVersion attribute) on the driver st_store. This leverages that version to attempt a re-profiling if this is ever updated. The same data is what is leveraged by the hub to re-interview a device on a device update as well.
This is built on top of the following PR: #2481 since that allows for more generic re-profiling of the parent devices.
Summary of Completed Tests
Tested that
try_update_metadataworks as expected for child devices.