Matter Camera: Include all supported resolutions #2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 71 files 480 suites 0s ⏱️ Results for commit bf77d63. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against bf77d63 |
samadDotDev
approved these changes
Jan 14, 2026
hcarter-775
approved these changes
Jan 14, 2026
hcarter-775
reviewed
Jan 14, 2026
| local max_encoded_pixel_rate = device:get_field(camera_fields.MAX_ENCODED_PIXEL_RATE) | ||
| local max_fps = device:get_field(camera_fields.MAX_FRAMES_PER_SECOND) | ||
| local emit_capability = max_encoded_pixel_rate ~= nil and max_fps ~= nil | ||
| local emit_capability = max_encoded_pixel_rate ~= nil and max_fps ~= nil and device:get_field(camera_fields.MIN_RESOLUTION) and device:get_field(camera_fields.MAX_RESOLUTION) |
Contributor
There was a problem hiding this comment.
just a nit, but if this is only being used to gate that if statement, maybe we should just put this in the statement itself? Like if <all this boolean stuff> then, and remove this variable altogether? Confused me a bit reading this initially.
Also, if you go with this suggestion, maybe make all of these booleans either use the explicit "~= nil" syntax or make them all implicit, rather than a mix of the 2?
Contributor
Author
There was a problem hiding this comment.
Sure, made them all implicit in the latest commit. Also, I realized I could clean up some logic in video_sensor_parameters_handler (I developed that handler while using an embedded version of the CAVSM cluster and for some reason I wasn't able to directly index into VideoSensorParamsStruct. Now with the actual cluster it works just fine)
ctowns
approved these changes
Jan 14, 2026
This change adds logic for including the resolutions exposed by the VideoSensorParams and MinViewport attributes in supportedResolutions, rather than only looking at the resolution embedded within RateDistortionTradeOffPoints.
nickolas-deboom
force-pushed
the
fix/matter-camera-consider-video-sensor-params-and-min-viewport-resolution-when-setting-supported-resolutions
branch
from
916a41c to
bf77d63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds logic for including the resolutions exposed by the
VideoSensorParamsandMinViewportattributes insupportedResolutions, rather than only looking at the resolution embedded withinRateDistortionTradeOffPoints.