Skip to content

fix: schema apps in "review" state cannot be updated #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossiam merged 1 commit into from
Oct 28, 2024
Merged

fix: schema apps in "review" state cannot be updated #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-feet-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smartthings/cli": patch
---

Schema apps that are in review cannot be updated.
4 changes: 3 additions & 1 deletion packages/cli/src/commands/schema/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ export default class SchemaUpdateCommand extends APIOrganizationCommand<typeof S

const { schemaApp: original, organizationWasUpdated } =
await getSchemaAppEnsuringOrganization(this, id, this.flags)
if (original.certificationStatus === 'wwst' || original.certificationStatus === 'cst') {
if (original.certificationStatus === 'wwst' ||
original.certificationStatus === 'cst' ||
original.certificationStatus === 'review') {
const cancelMsgBase =
'Schema apps that have already been certified cannot be updated via the CLI'
const cancelMsg = organizationWasUpdated
Expand Down
Loading