refactor: add canned mock of exports from api-command #642
Conversation
|
rossiam
force-pushed
the
api-command-mocks
branch
from
f9e5c0b to
02486ad
Compare
| apiCommandBuilder: apiCommandBuilderMock, | ||
| apiDocsURL: apiDocsURLMock, | ||
| })) | ||
| const { apiCommandMock, apiCommandBuilderMock } = apiCommandMocks('../..') |
There was a problem hiding this comment.
I don't love that we need to pass in the directory prefix here but jest.unstable_mockModules works relative to the test itself. There might be a way to determine this in the module but I haven't found anything yet.
There was a problem hiding this comment.
I don't see a better way either. I suppose you could at least set a default (probably of ../../..) so you don't always have to pass it?
There was a problem hiding this comment.
I had considered that but decided against it because I was afraid someone (like me 😄) might cut-and-paste one without the value specified and wonder why it didn't work.
I've also just realized the small sample of use-cases we have right now might not be representative.
There was a problem hiding this comment.
Thinking about this for a nanosecond longer and I'm realizing we probably do have more commands at one level deep overall so maybe we should make a default of ../../..? 🤷
| apiCommandBuilder: apiCommandBuilderMock, | ||
| apiDocsURL: apiDocsURLMock, | ||
| })) | ||
| const { apiCommandMock, apiCommandBuilderMock } = apiCommandMocks('../..') |
There was a problem hiding this comment.
I don't see a better way either. I suppose you could at least set a default (probably of ../../..) so you don't always have to pass it?
2 participants
This an example of an attempt at making the unit tests a little less repetitive.