Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces runtime configuration types to support locating the runtime for an executable. The changes include the addition of new records and enums for runtime config options, minor formatting improvements in documentation and code, and a small fix in file encoding in InteropStructs.cs.
Reviewed Changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WoofWare.DotnetRuntimeLocator/RuntimeConfigOptions.cs | Adds records and enums for representing runtimeconfig.json content. |
| WoofWare.DotnetRuntimeLocator/InteropStructs.cs | Removes extraneous BOM character improving file consistency. |
| WoofWare.DotnetRuntimeLocator/DotnetEnvironmentInfo.cs | Improves documentation formatting and simplifies code style. |
| README.md | Refines the instructions for specifying the libhostfxr path. |
Files not reviewed (5)
- WoofWare.DotnetRuntimeLocator/Test/Test.fsproj: Language not supported
- WoofWare.DotnetRuntimeLocator/Test/TestRuntimeConfigParse.fs: Language not supported
- WoofWare.DotnetRuntimeLocator/WoofWare.DotnetRuntimeLocator.csproj: Language not supported
- WoofWare.DotnetRuntimeLocator/version.json: Language not supported
- flake.nix: Language not supported
| /// <summary> | ||
| /// The .NET runtime which this executable expects. | ||
| /// This is optional, because you can instead specify multiple Frameworks, in which case any of the frameworks | ||
| /// is acceptable (according to Claude; the MS docs are impenetrable as ever). |
There was a problem hiding this comment.
[nitpick] Consider revising this comment to remove informal language and unclear references (e.g., 'according to Claude') to improve clarity and professionalism.
Owner
Author
There was a problem hiding this comment.
Thank you for your kind feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation to allow the user to locate the runtime for an exe.