Fix build errors in MacOS (jerryscript)#2974
Merged
slaff merged 2 commits intoSmingHub:developfrom Sep 16, 2025
Merged
Conversation
This PR provides some maintenance fixes for the follow issues: - Patch CMake minimum version < 3.10: CI build is failing on MacOS - Fix missing IMPORT_FSTR data building with GCC 15.2 - `day_names_p` and `month_names_p` ill-defined
PR Summary
|
Contributor
@mikee47 We can switch this build to macos-14 instead of the new latest. |
Contributor
Author
|
|
Contributor
Author
Missed this! I'll let the current CI run to see what happens using llvm |
mikee47
force-pushed
the
fix/jerryscript-ci-errors
branch
from
e338a73 to
93e6e23
Compare
slaff
pushed a commit
to mikee47/Sming
that referenced
this pull request
Sep 16, 2025
This PR provides some maintenance fixes for the follow issues with jerryscript: - Patch CMake minimum version < 3.10: CI build is failing on MacOS - Fix missing IMPORT_FSTR data building with GCC 15.2 - `day_names_p` and `month_names_p` ill-defined MacOS CI runner latest now at version 15 (Sequoia) which uses clang 18 (up from 15).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides some maintenance fixes for the follow issues with jerryscript:
day_names_pandmonth_names_pill-definedMacOS CI runner latest now at version 15 (Sequoia) which uses clang 18 (up from 15).
TODO:
rbpflibrary is failing. Looks probable that we need to use a newer version of llvm, version 15 isn't found in MacOS runner.macos-latestchanged from version 14 to version 15 3 weeks ago.