Fix TRange issues with clip, contains and random#2987
Merged
slaff merged 3 commits intoSmingHub:developfrom Jan 23, 2026
Merged
Fix TRange issues with clip, contains and random#2987slaff merged 3 commits intoSmingHub:developfrom
TRange issues with clip, contains and random#2987slaff merged 3 commits intoSmingHub:developfrom
Conversation
…hods For instance, calling `TRange<int8_t>::clip()` with an `int` value which exceeds the natural range of `int8_t` then it is truncated and the clipping returns an unexpected value.
PR Summary
These changes will make our system more robust, flexible, and easy to debug, enhancing the quality of our product. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid truncation of parameter to TRange
clip()andcontains()methodsFor instance, if
TRange<int8_t>::clip()is passed anintvalue which exceeds the natural range ofint8_tthen it is truncated and the clipping returns an unexpected value. For example:Both
clipandcontainmethods are now declaredconstexprso they can be evaluated at compile time if required.Fix random() for 64-bit values. May need second 32-bit random value to cover range properly
Add tests.