Skip to content

Fix llhttp parser issues with closed connections#3010

Merged
slaff merged 2 commits intoSmingHub:developfrom
mikee47:fix/http-closed-connection
Feb 18, 2026
Merged

Fix llhttp parser issues with closed connections#3010
slaff merged 2 commits intoSmingHub:developfrom
mikee47:fix/http-closed-connection

Conversation

@mikee47
Copy link
Contributor

@mikee47 mikee47 commented Feb 16, 2026

Fixes #3006

  • HttpClientConnection re-initialises parser on connect, but this resets parser state and causes error
  • BasicHttpHeaders::parse needs to set parser.data as llhttp_init does not preserve this value (unlike http-parser)

TODO:

@what-the-diff
Copy link

what-the-diff bot commented Feb 16, 2026

PR Summary

  • Enhanced Initialization of HTTP Response
    This update offers a more flexible HTTP response setup. Now, it can determine how the HTTP response is initialized depending on whether the USE_LEGACY_HTTP_PARSER setting is on. This helps create a better balance between maintaining older functionality and embracing new improvements.

@mikee47 mikee47 changed the title Do not re-initialise llhttp parser with client connection Fix llhttp parser issues with closed connections Feb 16, 2026
@mikee47 mikee47 changed the title Fix llhttp parser issues with closed connections Fix llhttp parser issues with closed connections Feb 16, 2026
@slaff slaff added this to the 6.3.0 milestone Feb 17, 2026
@slaff slaff merged commit 2a2b664 into SmingHub:develop Feb 18, 2026
31 checks passed
@mikee47 mikee47 deleted the fix/http-closed-connection branch February 19, 2026 09:14
@slaff slaff removed the 3 - Review label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpClient closes connection using new llhttp parser

2 participants