feat: let delegate_noop can handle constGeneric#679
feat: let delegate_noop can handle constGeneric#679Decodetalkers wants to merge 1 commit intoSmithay:masterfrom
Conversation
0ac5b81 to
bb9f5ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 73.03% 73.03%
=======================================
Files 48 48
Lines 7841 7841
=======================================
Hits 5727 5727
Misses 2114 2114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks, the principle looks good, I'll take some time later to carefully review the macro. More generally for this change, would you mind:
|
2a378db to
424f600
Compare
Sure, I am happy to do this |
8c2e1ae to
2fca6dc
Compare
|
Does the macro as it is here support types with both const-generic and regular generics? Something like |
|
I just let |
|
I'm not sure about that, it seems to me that the pattern you used, |
|
Ah.. I see, I fogot that generic types can be muti types.. |
78fdbfb to
910a8f7
Compare
the macro of delegate_noop cannot handle like struct A<const X: unsize>, such kind of struct, so I want to fix it
910a8f7 to
bd57467
Compare
|
Ok, now it is ok.. I try add muti generic type, like struct A<const X: usize, Y: Sized, Z> {
it: Z
}it seems ok |
the macro of delegate_noop cannot handle like
struct A<const X: unsize>, such kind of struct, so I want to fix it