Closed
Conversation
elinorbgr
requested changes
May 29, 2024
Member
elinorbgr
left a comment
elinorbgr
left a comment
There was a problem hiding this comment.
On the high-level principle LGTM, but see my comments for the implementation.
Also, I think we should add some tests to the wayland-backend test module to cover these API. I'm thinking at least the two cases : trying to destroy the same object twice, and trying to send a message through an object after it has already been manually destroyed.
ids1024
force-pushed
the
destroy-object
branch
from
3b0339d to
10b6ff0
Compare
This is needed for implementing the `wl_fixes` protocol. It should also make it possible to handle the requirement in `zwlr_output_configuration_v1::destroy` to destroy the `wlr_output_configuration_head`.
ids1024
force-pushed
the
destroy-object
branch
from
10b6ff0 to
853d975
Compare
Member
Author
|
Closed in favor of #826, which merged this along with tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for implementing the
wl_fixesprotocol. It should also make it possible to handle the requirement inzwlr_output_configuration_v1::destroyto destroy thewlr_output_configuration_head.Split off from #726. See Smithay/smithay#1428 and rust-windowing/softbuffer#218 for server-side and client-side uses of this.