update docs #19
update docs #19
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Crafter library documentation by adding a new page for flags and reorganizing the function tag documentation. The changes improve documentation clarity by moving advanced features into dedicated sections.
- Adds comprehensive documentation for crafting flags (consume_buckets, consume_tools)
- Documents the
#smithed.crafter:event/query_tagsfunction tag with usage examples - Reorganizes advanced uses section by moving specific features to dedicated pages
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/libraries/crafter/index.md | Adds new flags page to the documentation table of contents |
| docs/libraries/crafter/function_tag.md | Adds query_tags event documentation and updates advanced uses section with corrected links |
| docs/libraries/crafter/flags.md | New file documenting flag system for customizing item removal during crafting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Advanced uses : | ||
| A list of advanced uses of the crafter library. | ||
|
|
||
| - [Custom crafting table](https://github.com/Smithed-MC/Libraries/blob/main/smithed_libraries/packs/crafter/data/smithed.crafter/function/impl/block/table/break/drop_item.mcfunction) To register your own crafting table. |
There was a problem hiding this comment.
The URL path contains 'function' instead of 'functions'. The correct path should be 'data/smithed.crafter/functions/impl/block/table/break/drop_item.mcfunction' to match standard Minecraft datapack structure.
| - [Custom crafting table](https://github.com/Smithed-MC/Libraries/blob/main/smithed_libraries/packs/crafter/data/smithed.crafter/function/impl/block/table/break/drop_item.mcfunction) To register your own crafting table. | |
| - [Custom crafting table](https://github.com/Smithed-MC/Libraries/blob/main/smithed_libraries/packs/crafter/data/smithed.crafter/functions/impl/block/table/break/drop_item.mcfunction) To register your own crafting table. |
| | 'Success of operation' | score | $temp | smithed.data | | ||
| | 'Item to replace in the crafter' | entity | @s | weapon.mainhand | | ||
|
|
||
| The default value of 'Success of operation' is 0, which by default juste remove one item. This whould be the default behavior if your flag is not present. If your flag is present and you want to change the item, set it to 1. |
There was a problem hiding this comment.
There's a spelling error in "whould" which should be "would".
| The default value of 'Success of operation' is 0, which by default juste remove one item. This whould be the default behavior if your flag is not present. If your flag is present and you want to change the item, set it to 1. | |
| The default value of 'Success of operation' is 0, which by default juste remove one item. This would be the default behavior if your flag is not present. If your flag is present and you want to change the item, set it to 1. |
| | 'Success of operation' | score | $temp | smithed.data | | ||
| | 'Item to replace in the crafter' | entity | @s | weapon.mainhand | | ||
|
|
||
| The default value of 'Success of operation' is 0, which by default juste remove one item. This whould be the default behavior if your flag is not present. If your flag is present and you want to change the item, set it to 1. |
There was a problem hiding this comment.
There's a spelling error in "juste" which should be "just".
| The default value of 'Success of operation' is 0, which by default juste remove one item. This whould be the default behavior if your flag is not present. If your flag is present and you want to change the item, set it to 1. | |
| The default value of 'Success of operation' is 0, which by default just remove one item. This whould be the default behavior if your flag is not present. If your flag is present and you want to change the item, set it to 1. |
|
|
||
| ### `#smithed.crafter:event/advanced_remove` | ||
|
|
||
| Register a function to to this function tag, this function has the following inputs : |
There was a problem hiding this comment.
There's a grammatical error in the sentence. "Register a function to to this function tag" contains a duplicated "to". It should be "Register a function to this function tag".
| Register a function to to this function tag, this function has the following inputs : | |
| Register a function to this function tag, this function has the following inputs : |
| | 'Item to process' | entity | @s | weapon.mainhand | | ||
| | 'Flags list' | storage | smithed.crafter:input | flags | | ||
|
|
||
| And you need update the following output : |
There was a problem hiding this comment.
There's a grammatical error. "And you need update the following output" is missing "to" before "update". It should be "And you need to update the following output".
| And you need update the following output : | |
| And you need to update the following output : |
No description provided.